ppapi/proxy/ppb_buffer_proxy.h - Issue 1154613006: Update pepper to not assume that SharedMemoryHandle is an int.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppb_buffer_proxy.h

Issue 1154613006: Update pepper to not assume that SharedMemoryHandle is an int. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another nits pass. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/ppb_buffer_proxy.h

diff --git a/ppapi/proxy/ppb_buffer_proxy.h b/ppapi/proxy/ppb_buffer_proxy.h

index b1484947ecb18c7156c58c1ae7db75cc19f65926..2c131a0948a90fa7e53eee01805323a447338b14 100644

--- a/ppapi/proxy/ppb_buffer_proxy.h

+++ b/ppapi/proxy/ppb_buffer_proxy.h

@@ -36,7 +36,7 @@ class Buffer : public thunk::PPB_Buffer_API, public Resource {

void Unmap() override;

// Trusted

- int32_t GetSharedMemory(int* handle) override;

+ int32_t GetSharedMemory(base::SharedMemory** shm) override;

private:

base::SharedMemory shm_;

« no previous file with comments | « ppapi/proxy/ppb_audio_proxy.cc ('k') | ppapi/proxy/ppb_buffer_proxy.cc » ('j') | ppapi/thunk/ppb_image_data_api.h » ('J')