Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2170)

Unified Diff: content/renderer/pepper/pepper_audio_input_host.cc

Issue 1154613006: Update pepper to not assume that SharedMemoryHandle is an int. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another nits pass. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/pepper_audio_input_host.cc
diff --git a/content/renderer/pepper/pepper_audio_input_host.cc b/content/renderer/pepper/pepper_audio_input_host.cc
index e96e7ea3d524f6ea1366863a7e275a968af9cb80..1805eb7d3f7aa06e2dc7bbd95dfb086aec575162 100644
--- a/content/renderer/pepper/pepper_audio_input_host.cc
+++ b/content/renderer/pepper/pepper_audio_input_host.cc
@@ -172,9 +172,10 @@ int32_t PepperAudioInputHost::GetRemoteHandles(
if (*remote_socket_handle == IPC::InvalidPlatformFileForTransit())
return PP_ERROR_FAILED;
- *remote_shared_memory_handle = renderer_ppapi_host_->ShareHandleWithRemote(
- PlatformFileFromSharedMemoryHandle(shared_memory.handle()), false);
- if (*remote_shared_memory_handle == IPC::InvalidPlatformFileForTransit())
+ *remote_shared_memory_handle =
+ renderer_ppapi_host_->ShareSharedMemoryHandleWithRemote(
+ shared_memory.handle());
+ if (!base::SharedMemory::IsHandleValid(*remote_shared_memory_handle))
return PP_ERROR_FAILED;
return PP_OK;

Powered by Google App Engine
This is Rietveld 408576698