content/renderer/pepper/audio_helper.h - Issue 1154613006: Update pepper to not assume that SharedMemoryHandle is an int.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/audio_helper.h

Issue 1154613006: Update pepper to not assume that SharedMemoryHandle is an int. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another nits pass. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/audio_helper.h

diff --git a/content/renderer/pepper/audio_helper.h b/content/renderer/pepper/audio_helper.h

index 94f94fcfb4c80bbb4a3b13456a9d08a263a48bb1..4b0dfc2a5d18b6cf20ad3f5451f33b88c16f3256 100644

--- a/content/renderer/pepper/audio_helper.h

+++ b/content/renderer/pepper/audio_helper.h

@@ -33,7 +33,7 @@ class AudioHelper {

// To be called by implementations of |PPB_Audio_API|/|PPB_AudioInput_API|.

int32_t GetSyncSocketImpl(int* sync_socket);

- int32_t GetSharedMemoryImpl(int* shm_handle, uint32_t* shm_size);

+ int32_t GetSharedMemoryImpl(base::SharedMemory** shm, uint32_t* shm_size);

// To be implemented by subclasses to call their |SetStreamInfo()|.

virtual void OnSetStreamInfo(base::SharedMemoryHandle shared_memory_handle,

« no previous file with comments | « content/renderer/npapi/webplugin_delegate_proxy.cc ('k') | content/renderer/pepper/audio_helper.cc » ('j') | ppapi/thunk/ppb_image_data_api.h » ('J')