Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2564)

Unified Diff: content/renderer/pepper/ppb_buffer_impl.cc

Issue 1154613006: Update pepper to not assume that SharedMemoryHandle is an int. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from piman. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/ppb_buffer_impl.cc
diff --git a/content/renderer/pepper/ppb_buffer_impl.cc b/content/renderer/pepper/ppb_buffer_impl.cc
index a818fce5530d4edc554f019b538caa25c5bd41d1..e044c6b86446d124291e4208a20c5cd68f81877d 100644
--- a/content/renderer/pepper/ppb_buffer_impl.cc
+++ b/content/renderer/pepper/ppb_buffer_impl.cc
@@ -78,9 +78,8 @@ void PPB_Buffer_Impl::Unmap() {
shared_memory_->Unmap();
}
-int32_t PPB_Buffer_Impl::GetSharedMemory(int* shm_handle) {
- *shm_handle = reinterpret_cast<int>(PlatformFileFromSharedMemoryHandle(
- shared_memory_->handle()));
+int32_t PPB_Buffer_Impl::GetSharedMemory(base::SharedMemory* shm) {
+ shm = shared_memory_.get();
piman 2015/06/02 00:00:15 Same here
erikchen 2015/06/02 00:28:37 Fixed.
return PP_OK;
}

Powered by Google App Engine
This is Rietveld 408576698