Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 115460: Merge bleeding_edge@1955 to 1.1 branch to improve compilation... (Closed)

Created:
11 years, 7 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
iposva
Visibility:
Public.

Description

Merge bleeding_edge@1955 to 1.1 branch to improve compilation cache behavior on for real web pages by allowing compiled scripts to survive a few GCs in the cache. Committed: http://code.google.com/p/v8/source/detail?r=1992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -41 lines) Patch
M ChangeLog View 1 chunk +11 lines, -3 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compilation-cache.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/compilation-cache.cc View 3 chunks +61 lines, -31 lines 0 comments Download
M test/cctest/test-api.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kasper Lund
This is a change proposal for the 1.1 branch. It's pretty simple, but we haven't ...
11 years, 7 months ago (2009-05-18 08:54:47 UTC) #1
Mads Ager (chromium)
LGTM
11 years, 7 months ago (2009-05-18 09:00:33 UTC) #2
Kasper Lund
Update: I just verified that without this fix, we never hit the compilation cache when ...
11 years, 7 months ago (2009-05-18 09:11:52 UTC) #3
Kasper Lund
Pushed to the 1.1 branch in revision 1992: http://v8.googlecode.com/svn/branches/1.1@1992 Feel free to revert this if ...
11 years, 7 months ago (2009-05-18 13:57:07 UTC) #4
Mark Larson
11 years, 7 months ago (2009-05-18 16:43:09 UTC) #5
On 2009/05/18 13:57:07, Kasper Lund wrote:
> Pushed to the 1.1 branch in revision 1992:
> 
>    http://v8.googlecode.com/svn/branches/1.1@1992
> 
> Feel free to revert this if you decide not to land this in 172.x and you need
to
> land other critical patches.

OK. The 172 release is code-frozen at the moment, so this will only go in if we
decide to delay ship (or when we do a 172 update).

Powered by Google App Engine
This is Rietveld 408576698