Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2003)

Unified Diff: appengine/findit/waterfall/test/build_failure_analysis_test.py

Issue 1154593005: [Findit] Add a sub-pipeline to analyze failures caused by DEPS rolls. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Address comments. Still working on unittests. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/build_failure_analysis_test.py
diff --git a/appengine/findit/waterfall/test/build_failure_analysis_test.py b/appengine/findit/waterfall/test/build_failure_analysis_test.py
index 8fbd51e8e545c923a83b148a34f233bb5db133cb..e2b6907bb53c82aac67c27df79eff5f0ebf5fab8 100644
--- a/appengine/findit/waterfall/test/build_failure_analysis_test.py
+++ b/appengine/findit/waterfall/test/build_failure_analysis_test.py
@@ -113,7 +113,7 @@ class BuildFailureAnalysisTest(unittest.TestCase):
}
justification = build_failure_analysis._CheckFiles(
- FailureSignal.FromDict(failure_signal_json), change_log_json)
+ FailureSignal.FromDict(failure_signal_json), change_log_json, {})
self.assertIsNotNone(justification)
# The score is 14 because:
# +5 added a/b/f1.cc (same file src/a/b/f1.cc in failure_signal log)
@@ -142,7 +142,7 @@ class BuildFailureAnalysisTest(unittest.TestCase):
}
justification = build_failure_analysis._CheckFiles(
- FailureSignal.FromDict(failure_signal_json), change_log_json)
+ FailureSignal.FromDict(failure_signal_json), change_log_json, {})
self.assertIsNone(justification)
def testAnalyzeSuccessfulBuild(self):
@@ -150,7 +150,7 @@ class BuildFailureAnalysisTest(unittest.TestCase):
'failed': False,
}
result = build_failure_analysis.AnalyzeBuildFailure(
- failure_info, None, None)
+ failure_info, None, None, None)
self.assertEqual(0, len(result['failures']))
def testAnalyzeBuildFailure(self):
@@ -239,6 +239,10 @@ class BuildFailureAnalysisTest(unittest.TestCase):
],
},
}
+ deps_info = {
+ 'deps_rolls': {},
+ 'current_deps': {},
+ }
failure_signals_json = {
'a': {
'files': {
@@ -293,5 +297,5 @@ class BuildFailureAnalysisTest(unittest.TestCase):
}
analysis_result = build_failure_analysis.AnalyzeBuildFailure(
- failure_info, change_logs, failure_signals_json)
+ failure_info, change_logs, deps_info, failure_signals_json)
self.assertEqual(expected_analysis_result, analysis_result)

Powered by Google App Engine
This is Rietveld 408576698