Index: appengine/findit/waterfall/build_failure_analysis.py |
diff --git a/appengine/findit/waterfall/build_failure_analysis.py b/appengine/findit/waterfall/build_failure_analysis.py |
index d1ecd1bf369682b301b13b498fd59ef72ad08c68..c7ae6dfc3e4f7b5bf1cdd926b1bd6db920c5d634 100644 |
--- a/appengine/findit/waterfall/build_failure_analysis.py |
+++ b/appengine/findit/waterfall/build_failure_analysis.py |
@@ -276,12 +276,15 @@ def _CheckFiles(failure_signal, change_log): |
return justification.ToDict() |
-def AnalyzeBuildFailure(failure_info, change_logs, failure_signals): |
+# TODO: use DEPS info to detect dependency rolls -- pylint: disable=W0613 |
+def AnalyzeBuildFailure( |
+ failure_info, change_logs, deps_info, failure_signals): |
"""Analyze the given failure signals, and figure out culprit CLs. |
Args: |
failure_info (dict): Output of pipeline DetectFirstFailurePipeline. |
change_logs (dict): Output of pipeline PullChangelogPipeline. |
+ deps_info (dict): Output of pipeline ExtractDEPSInfoPipeline. |
chanli
2015/05/29 01:00:07
Why I can't find where do you use this argument in
stgao
2015/05/29 16:46:54
I added a TODO above for that.
However, I made a
|
failure_signals (dict): Output of pipeline ExtractSignalPipeline. |
Returns: |