appengine/findit/waterfall/build_failure_analysis.py - Issue 1154593005: [Findit] Add a sub-pipeline to analyze failures caused by DEPS rolls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/build_failure_analysis.py

Issue 1154593005: [Findit] Add a sub-pipeline to analyze failures caused by DEPS rolls. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Unittests will be added in next patch. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/analyze_build_failure_pipeline.py ('k') | appengine/findit/waterfall/detect_first_failure_pipeline.py » ('j') | appengine/findit/waterfall/extract_deps_info_pipeline.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/build_failure_analysis.py

diff --git a/appengine/findit/waterfall/build_failure_analysis.py b/appengine/findit/waterfall/build_failure_analysis.py

index d1ecd1bf369682b301b13b498fd59ef72ad08c68..c7ae6dfc3e4f7b5bf1cdd926b1bd6db920c5d634 100644

--- a/appengine/findit/waterfall/build_failure_analysis.py

+++ b/appengine/findit/waterfall/build_failure_analysis.py

@@ -276,12 +276,15 @@ def _CheckFiles(failure_signal, change_log):

return justification.ToDict()

-def AnalyzeBuildFailure(failure_info, change_logs, failure_signals):

+# TODO: use DEPS info to detect dependency rolls -- pylint: disable=W0613

+def AnalyzeBuildFailure(

+ failure_info, change_logs, deps_info, failure_signals):

"""Analyze the given failure signals, and figure out culprit CLs.

Args:

failure_info (dict): Output of pipeline DetectFirstFailurePipeline.

change_logs (dict): Output of pipeline PullChangelogPipeline.

+ deps_info (dict): Output of pipeline ExtractDEPSInfoPipeline.

chanli 2015/05/29 01:00:07 Why I can't find where do you use this argument in

stgao 2015/05/29 16:46:54 I added a TODO above for that. However, I made a

failure_signals (dict): Output of pipeline ExtractSignalPipeline.

Returns: