appengine/findit/waterfall/identify_culprit_pipeline.py - Issue 1154593005: [Findit] Add a sub-pipeline to analyze failures caused by DEPS rolls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/identify_culprit_pipeline.py

Issue 1154593005: [Findit] Add a sub-pipeline to analyze failures caused by DEPS rolls. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Improve readability. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/extract_deps_info_pipeline.py ('k') | appengine/findit/waterfall/test/analyze_build_failure_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/identify_culprit_pipeline.py

diff --git a/appengine/findit/waterfall/identify_culprit_pipeline.py b/appengine/findit/waterfall/identify_culprit_pipeline.py

index 6006767053a27ac48efbce7f4cec14021882f5df..1f19a46debab5ef96c7cf61017c4ba7f69cceb71 100644

--- a/appengine/findit/waterfall/identify_culprit_pipeline.py

+++ b/appengine/findit/waterfall/identify_culprit_pipeline.py

@@ -23,7 +23,7 @@ def _GetResultAnalysisStatus(analysis_result):

return None

for failure in analysis_result['failures']:

- if failure['suspected_cls']:

+ if failure['suspected_cls']:

return wf_analysis_result_status.FOUND_UNTRIAGED

return wf_analysis_result_status.NOT_FOUND_UNTRIAGED

@@ -52,7 +52,7 @@ class IdentifyCulpritPipeline(BasePipeline):

"""A pipeline to identify culprit CLs for a build failure."""

# Arguments number differs from overridden method - pylint: disable=W0221

- def run(self, failure_info, change_logs, signals):

+ def run(self, failure_info, change_logs, deps_info, signals):

"""

Args:

failure_info (dict): Output of pipeline DetectFirstFailurePipeline.

@@ -68,7 +68,7 @@ class IdentifyCulpritPipeline(BasePipeline):

build_number = failure_info['build_number']

analysis_result = build_failure_analysis.AnalyzeBuildFailure(

- failure_info, change_logs, signals)

+ failure_info, change_logs, deps_info, signals)

analysis = WfAnalysis.Get(master_name, builder_name, build_number)

analysis.result = analysis_result

analysis.status = wf_analysis_status.ANALYZED