[Findit] Add a sub-pipeline to analyze failures caused by DEPS rolls.

appengine/findit/common/chromium_deps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from common import git_repository
 from common import http_client_appengine
 from common import dependency
 from common import deps_parser
 
 
 class DEPSDownloader(deps_parser.DEPSLoader):
-  """Download DEPS from remote GIT repo."""
+  """Downloads DEPS from remote GIT repo."""

[qyearsley, 2015/05/29 23:14:33]

GIT -> git or Git

[stgao, 2015/05/30 00:21:05]

Done.

 
   def Load(self, repo_url, revision, deps_file):
     http_client = http_client_appengine.HttpClientAppengine()
     repo = git_repository.GitRepository(repo_url, http_client)
 
     content = None
 
     # Try .DEPS.git first if the given deps_file is "DEPS", because before
     # migration from SVN to GIT, .DEPS.git contains dependencies from GIT while

[qyearsley, 2015/05/29 23:14:32]

GIT -> git or Git

[stgao, 2015/05/30 00:21:05]

Done.

     # DEPS contains those from SVN.
     if deps_file == 'DEPS':
       content = repo.GetSource('.DEPS.git', revision)
 
     # If .DEPS.git is not found, use DEPS. Assume it is a commit after migration
     # from SVN to GIT.
     if content is None:
       content = repo.GetSource(deps_file, revision)
 
     if content is None:
       raise Exception('Failed to pull %s file.' % deps_file)
 
     return content
 
 
 def GetChromeDependency(revision, os_platform):
-  """Return all dependencies of Chrome as a dict for the given revision and os.
+  """Returns all dependencies of Chrome as a dict for the given revision and os.

[qyearsley, 2015/05/29 23:14:33]

Nit: os -> OS

[stgao, 2015/05/30 00:21:05]

Done.

 
   Args:
     revision (str): The revision of a Chrome build.
     os_platform (str): The target platform of the Chrome build, should be one of
         'win', 'ios', 'mac', 'unix', 'android', or 'all'.
 
   Returns:
     A map from dependency path to the dependency info.
   """
   root_dep = dependency.Dependency(
       'src/', 'https://chromium.googlesource.com/chromium/src.git', revision,
       'DEPS')
 
   deps_parser.UpdateDependencyTree(root_dep, [os_platform], DEPSDownloader())
 
   dependencies = {}
 
   # Flatten the dependency tree into a one-level dict.
-  def _FlattenDepTree(dep):
+  def FlattenDepTree(dep):
     dependencies[dep.path] = dep
     for child in dep.children.values():
-      _FlattenDepTree(child)
+      FlattenDepTree(child)
 
-  _FlattenDepTree(root_dep)
+  FlattenDepTree(root_dep)
 
   return dependencies
+
+
+def GetChromiumDEPSRolls(old_cr_revision, new_cr_revision, os_platform):
+  """Returns a list of dependency rolls between the given Chromium revisions.
+
+  Args:
+    old_cr_revision (str): The old Chromium revision.
+    new_cr_revision (str): The new Chromium revision.

[qyearsley, 2015/05/29 23:14:33]

Are these git commit hashes or commit positions or either?

[stgao, 2015/05/30 00:21:05]

Done.
Git commit hashes.

+    os_platform (str): The target OS platform of the Chrome or test binary.
+  """
+  old_deps = GetChromeDependency(old_cr_revision, os_platform)
+  new_deps = GetChromeDependency(new_cr_revision, os_platform)
+
+  rolls = []
+
+  for path, new_dep in new_deps.iteritems():
+    if path == 'src/':
+      continue
+
+    old_revision = None
+    if path in old_deps:
+      old_revision = old_deps[path].revision
+
+    if old_revision != new_dep.revision:
+      rolls.append(
+          dependency.DependencyRoll(
+              path, new_dep.repo_url, old_revision, new_dep.revision))
+
+  # Note: dependencies could be deleted too. However, regressions caused by that
+  # seems rare. Thus, ignore them for now.
+
+  return rolls