LayoutTests/http/tests/storage/durability-basics.html - Issue 1154573005: Expose Durable Storage API to script

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/storage/durability-basics.html

Issue 1154573005: Expose Durable Storage API to script (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix up ScriptPromiseResolver Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/http/tests/security/powerfulFeatureRestrictions/durable-storage-on-insecure-origin.html ('k') | Source/modules/modules.gypi » ('j') | Source/modules/quota/StorageManager.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>navigator.storage methods return promises that are fulfilled</title>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <script>

	6

	7 test(function() { assert_true(!!navigator.storage); }, "These tests requires nav igator.storage");
	jsbell 2015/08/10 17:49:41 Nit (if you're touching this file) - can you forma Nit (if you're touching this file) - can you format so the test fits in 80 cols? (not a hard rule, but we're generally trying to follow that in testharness.js-based tests) dgrogan 2015/08/10 18:39:56 Done. Show quoted text On 2015/08/10 17:49:41, jsbell wrote: > Nit (if you're touching this file) - can you format so the test fits in 80 cols? > (not a hard rule, but we're generally trying to follow that in > testharness.js-based tests) Done.
	8

	9 promise_test(function() {

	10 var promise = navigator.storage.requestPersistent();

	11 assert_true(promise instanceof Promise, "navigator.storage.requestPersistent () returned a Promise.")

	12 return promise.then(function (result) {

	13 assert_equals(typeof result, "string", result + " should be a string");
	jsbell 2015/08/10 17:49:41 As we've discussed offline, layout tests get canne As we've discussed offline, layout tests get canned results, not the strings per spec. Can you add a comment here explaining that? dgrogan 2015/08/10 18:39:56 Done. Show quoted text On 2015/08/10 17:49:41, jsbell wrote: > As we've discussed offline, layout tests get canned results, not the strings per > spec. Can you add a comment here explaining that? Done.
	14 assert_greater_than(result.length, 0, "result should have length >0");

	15 });

	16 }, "navigator.storage.requestPersistent returns a promise that resolves.");

	17

	18 promise_test(function() {

	19 var promise = navigator.storage.persistentPermission();

	20 assert_true(promise instanceof Promise, "navigator.storage.persistentPermiss ion() returned a Promise.")

	21 return promise.then(function (result) {

	22 assert_equals(typeof result, "string", result + " should be a string");

	23 assert_greater_than(result.length, 0, "result should have length >0");

	24 });

	25 }, "navigator.storage.persistentPermission returns a promise that resolves.");

	26

	27 </script>

OLD	NEW