Source/modules/quota/StorageManager.h - Issue 1154573005: Expose Durable Storage API to script

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/quota/StorageManager.h

Issue 1154573005: Expose Durable Storage API to script (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: update comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/modules/quota/NavigatorStorageQuota.idl ('K') | « Source/modules/quota/NavigatorStorageQuota.idl ('k') | Source/modules/quota/StorageManager.cpp » ('j') | Source/modules/quota/StorageManager.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef StorageManager_h

	6 #define StorageManager_h

	7

	8 #include "bindings/core/v8/ScriptPromise.h"
	jsbell 2015/08/03 19:57:41 Can ScriptPromise and ScriptState be forward-decla Can ScriptPromise and ScriptState be forward-declarations rather than #includes? dgrogan 2015/08/06 23:52:02 Done. Show quoted text On 2015/08/03 19:57:41, jsbell wrote: > Can ScriptPromise and ScriptState be forward-declarations rather than #includes? Done.
	9 #include "bindings/core/v8/ScriptState.h"

	10 #include "bindings/core/v8/ScriptWrappable.h"

	11 #include "platform/heap/Heap.h"

	12

	13 namespace blink {

	14

	15 class StorageManager final : public GarbageCollected<StorageManager>, public Scr iptWrappable { // Cargo culted
	jsbell 2015/08/03 19:57:41 Ditch the 'cargo culted' comments. This is correct Ditch the 'cargo culted' comments. This is correct. dgrogan 2015/08/06 23:52:02 Thanks! Show quoted text On 2015/08/03 19:57:41, jsbell wrote: > Ditch the 'cargo culted' comments. This is correct. Thanks!
	16 DEFINE_WRAPPERTYPEINFO(); // Cargo culted

	17 public:

	18 ScriptPromise requestPersistent(ScriptState*);

	19 ScriptPromise persistentPermission(ScriptState*);

	20 DEFINE_INLINE_TRACE() { } // Cargo culted
	mlamouri (slow - plz ping) 2015/08/04 13:15:19 Inlining isn't recommended: https://www.chromium.o Inlining isn't recommended: https://www.chromium.org/developers/coding-style#TOC-Inline-functions Could you DECLARE_TRACE() / DEFINE_TRACE() ? dgrogan 2015/08/06 23:52:02 Done. Though note that the blink style guide is mo Show quoted text On 2015/08/04 13:15:19, Mounir Lamouri wrote: > Inlining isn't recommended: > https://www.chromium.org/developers/coding-style#TOC-Inline-functions > > Could you DECLARE_TRACE() / DEFINE_TRACE() ? Done. Though note that the blink style guide is mostly silent on inline functions. And it doesn't generally refer back to the chromium style guide, only in specific situations.
	21 };

	22

	23 } // namespace blink

	24

	25 #endif // StorageManager_h

OLD	NEW