LayoutTests/storage/quota/durability-basics.html - Issue 1154573005: Expose Durable Storage API to script

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/storage/quota/durability-basics.html

Issue 1154573005: Expose Durable Storage API to script (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: update comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	jsbell 2015/08/03 19:57:41 Since this is not under http/tests this is implici Since this is not under http/tests this is implicitly running as file:/// rather than http/https. I'd recommend moving it there (and/or copying it, if you want to maintain the file:/// aspect, which might be worthwhile...) We'd also want a test case where the requests are done in an non-secure origin and hence fail. jsbell 2015/08/03 23:11:16 ... and this can be based on (and live with) the t Show quoted text On 2015/08/03 19:57:41, jsbell wrote: > We'd also want a test case where the requests are done in an non-secure origin > and hence fail. ... and this can be based on (and live with) the tests in LayoutTests/http/tests/security/powerfulFeatureRestrictions dgrogan 2015/08/06 23:52:01 Done. Show quoted text On 2015/08/03 23:11:16, jsbell wrote: > On 2015/08/03 19:57:41, jsbell wrote: > > We'd also want a test case where the requests are done in an non-secure origin > > and hence fail. > > ... and this can be based on (and live with) the tests in > LayoutTests/http/tests/security/powerfulFeatureRestrictions Done.
	2 <title>navigator.storage methods return promises that are fulfilled</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script type="text/javascript">
	jsbell 2015/08/03 19:57:41 No need for type here No need for type here dgrogan 2015/08/06 23:52:01 Done. Show quoted text On 2015/08/03 19:57:41, jsbell wrote: > No need for type here Done.
	6

	7 test(function() { assert_true(!!navigator.storage); }, "These tests requires nav igator.storage");

	8

	9 promise_test(function() {

	10 var promise = navigator.storage.requestPersistent();

	11 assert_true(promise instanceof Promise, "navigator.storage.requestPersistent () returned a Promise.")

	12 return promise;
	jsbell 2015/08/03 19:57:41 This looks like it's missing the test of the promi This looks like it's missing the test of the promise result itself? dgrogan 2015/08/06 23:52:01 That was intentional, content/shell/browser/layout Show quoted text On 2015/08/03 19:57:41, jsbell wrote: > This looks like it's missing the test of the promise result itself? That was intentional, content/shell/browser/layout_test/layout_test_permission_manager.cc just returns DENIED unless something was set beforehand via testRunner.setPermission(). I _could_ add such a call and test the promise result but it'd just be testing the testRunner plumbing, nothing real. I suppose I could add a test that the result is a non-zero-length string.
	13 }, "navigator.storage.requestPersistent returns a promise that resolves.");

	14

	15 promise_test(function() {

	16 var promise = navigator.storage.persistentPermission();

	17 assert_true(promise instanceof Promise, "navigator.storage.persistentPermiss ion() returned a Promise.")

	18 return promise;
	jsbell 2015/08/03 19:57:41 Ditto? Ditto? dgrogan 2015/08/06 23:52:01 Acknowledged. Show quoted text On 2015/08/03 19:57:41, jsbell wrote: > Ditto? Acknowledged.
	19 }, "navigator.storage.persistentPermission returns a promise that resolves.");

	20

	21 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/modules/modules.gypi » ('j') | Source/modules/quota/DEPS » ('J')