LayoutTests/storage/quota/durability.html - Issue 1154573005: Expose Durable Storage API to script

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/storage/quota/durability.html

Issue 1154573005: Expose Durable Storage API to script (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: respond to jsbell comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>requestPersistent returns a promise that is fulfilled</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script type="text/javascript">

	6

	7 test(function() { assert_true(!!navigator.storage); }, "This test requires navig ator.storage");

	8 promise_test(function(the_test) {

	9 var promise = navigator.storage.requestPersistent();

	10 // assert_class_string(promise, "Promise");
	dgrogan 2015/07/07 04:25:14 jsbell@: I'd like to test 2 things here. 1) navig jsbell@: I'd like to test 2 things here. 1) navigator.storage.requestPersistent returns a promise. I was hoping that promise_test would handle that for me but it does not as returning a string from this function doesn't cause failure. assert_class_string fails because it is an Object, not a Promise. Recommendations? Should I check that \|promise\| has a .then() method? 2) The promise resolves, not rejects. https://github.com/w3c/testharness.js/blob/master/docs/api.md#promise-tests says "The test completes when the returned promise resolves. The test fails if the returned promise rejects," but I'm not seeing that. Forcing the promise to reject in C++ still results in the test passing. Again, recommendations? We can talk in person tomorrow. There's a decent chance I have a fundamental misunderstanding somewhere. jsbell 2015/07/07 16:51:04 The return value is automagically wrapped in a pro Show quoted text On 2015/07/07 04:25:14, dgrogan wrote: > jsbell@: I'd like to test 2 things here. > > 1) navigator.storage.requestPersistent returns a promise. I was hoping that > promise_test would handle that for me but it does not as returning a string from > this function doesn't cause failure. assert_class_string fails because it is an > Object, not a Promise. Recommendations? Should I check that \|promise\| has a > .then() method? The return value is automagically wrapped in a promise, and the "class string" is Object for native JS object types. You should be able to do `foo instanceof Promise` Show quoted text > > 2) The promise resolves, not rejects. > https://github.com/w3c/testharness.js/blob/master/docs/api.md#promise-tests says > "The test completes when the returned promise resolves. The test fails if the > returned promise rejects," but I'm not seeing that. Forcing the promise to > reject in C++ still results in the test passing. Again, recommendations? That's odd - what you're doing sounds right, so something weird is going on. We can take a look together.
	11 return promise;

	12 }, "navigator.storage.requestPersistent returns a promise that resolves.");

	13

	14 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/modules/modules.gypi » ('j') | no next file with comments »