Fix for a memory leak in CacheFlushManager.

pkg/analyzer/test/src/context/cache_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.task.driver_test;
 
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/generated/engine.dart'
     show
         AnalysisContext,
@@ skipping 671 matching lines @@
     manager.resultStored(result1, null);
     manager.resultStored(result2, null);
     expect(manager.currentSize, 2);
     expect(manager.recentlyUsed, orderedEquals([result1, result2]));
     // access result3, no-op
     manager.resultAccessed(result3);
     expect(manager.currentSize, 2);
     expect(manager.recentlyUsed, orderedEquals([result1, result2]));
   }
 
+  test_resultAccessed_unlimitedCachingPolicy() {
+    manager = new CacheFlushManager(new SimpleResultCachingPolicy(-1, -1),
+        (AnalysisTarget target) => false);
+    ResultDescriptor descriptor1 = new ResultDescriptor('result1', null);
+    ResultDescriptor descriptor2 = new ResultDescriptor('result2', null);
+    AnalysisTarget target = new TestSource();
+    TargetedResult result1 = new TargetedResult(target, descriptor1);
+    TargetedResult result2 = new TargetedResult(target, descriptor2);
+    manager.resultStored(result1, null);
+    manager.resultStored(result2, null);
+    expect(manager.currentSize, 0);
+    expect(manager.recentlyUsed, isEmpty);
+    // access result2
+    manager.resultAccessed(result2);
+    expect(manager.currentSize, 0);
+    expect(manager.recentlyUsed, isEmpty);
+  }
+
   test_resultStored() {
     ResultDescriptor descriptor1 = new ResultDescriptor('result1', null);
     ResultDescriptor descriptor2 = new ResultDescriptor('result2', null);
     ResultDescriptor descriptor3 = new ResultDescriptor('result3', null);
     ResultDescriptor descriptor4 = new ResultDescriptor('result4', null);
     AnalysisTarget target = new TestSource();
     TargetedResult result1 = new TargetedResult(target, descriptor1);
     TargetedResult result2 = new TargetedResult(target, descriptor2);
     TargetedResult result3 = new TargetedResult(target, descriptor3);
     TargetedResult result4 = new TargetedResult(target, descriptor4);
@@ skipping 12 matching lines @@
     // store result4
     {
       List<TargetedResult> resultsToFlush = manager.resultStored(result4, null);
       expect(resultsToFlush, [result1]);
       expect(manager.currentSize, 3);
       expect(manager.recentlyUsed, orderedEquals([result3, result2, result4]));
       expect(manager.resultSizeMap, {result3: 1, result2: 1, result4: 1});
     }
   }
 
+  test_resultStored_unlimitedCachingPolicy() {
+    manager = new CacheFlushManager(new SimpleResultCachingPolicy(-1, -1),
+        (AnalysisTarget target) => false);
+    ResultDescriptor descriptor1 = new ResultDescriptor('result1', null);
+    ResultDescriptor descriptor2 = new ResultDescriptor('result2', null);
+    AnalysisTarget target = new TestSource();
+    TargetedResult result1 = new TargetedResult(target, descriptor1);
+    TargetedResult result2 = new TargetedResult(target, descriptor2);
+    manager.resultStored(result1, null);
+    manager.resultStored(result2, null);
+    expect(manager.currentSize, 0);
+    expect(manager.recentlyUsed, isEmpty);
+  }
+
   test_targetRemoved() {
     ResultDescriptor descriptor1 = new ResultDescriptor('result1', null);
     ResultDescriptor descriptor2 = new ResultDescriptor('result2', null);
     ResultDescriptor descriptor3 = new ResultDescriptor('result3', null);
     AnalysisTarget target1 = new TestSource('a.dart');
     AnalysisTarget target2 = new TestSource('b.dart');
     TargetedResult result1 = new TargetedResult(target1, descriptor1);
     TargetedResult result2 = new TargetedResult(target2, descriptor2);
     TargetedResult result3 = new TargetedResult(target1, descriptor3);
     manager.resultStored(result1, null);
@@ skipping 129 matching lines @@
 
 class _InternalAnalysisContextMock extends TypedMock
     implements InternalAnalysisContext {
   noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
 }
 
 class _TestAnalysisTarget implements AnalysisTarget {
   @override
   Source get source => null;
 }