Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6683)

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 115453004: Moves management of transients out of Window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove unneeded parens Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_popup.cc
diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc
index 3afafb1e3179ee00db0a351d69f3adff0e64dbaf..ea57e3df616f7c5ea34da693d15eb79237ba5ffe 100644
--- a/chrome/browser/ui/views/extensions/extension_popup.cc
+++ b/chrome/browser/ui/views/extensions/extension_popup.cc
@@ -32,6 +32,7 @@
#include "ui/aura/client/activation_client.h"
#include "ui/aura/window.h"
#include "ui/views/corewm/window_animations.h"
+#include "ui/views/corewm/window_util.h"
#endif
#if defined(OS_WIN)
@@ -197,7 +198,7 @@ void ExtensionPopup::OnWindowActivated(aura::Window* gained_active,
if (!inspect_with_devtools_ && anchor_window == gained_active &&
host_desktop_type != chrome::HOST_DESKTOP_TYPE_ASH &&
this_window->GetRootWindow() == anchor_window->GetRootWindow() &&
- gained_active->transient_parent() != this_window)
+ views::corewm::GetTransientParent(gained_active) != this_window)
GetWidget()->Close();
}
#endif

Powered by Google App Engine
This is Rietveld 408576698