chrome/browser/ui/views/extensions/extension_popup.cc - Issue 115453004: Moves management of transients out of Window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 115453004: Moves management of transients out of Window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix MRUWindowTracker and MultiProfileMultiBrowserShelfLayoutChromeLauncherControllerTest Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/extension_popup.cc

diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc

index 4920c42ee170abd9a4a72f74da47a8bee5b21041..53d089500ec688e51881dd3b17bc44446486b63b 100644

--- a/chrome/browser/ui/views/extensions/extension_popup.cc

+++ b/chrome/browser/ui/views/extensions/extension_popup.cc

@@ -30,6 +30,7 @@

#if defined(USE_AURA)

#include "ui/aura/client/activation_client.h"

#include "ui/aura/window.h"

+#include "ui/views/corewm/transient_window_manager.h"

#include "ui/views/corewm/window_animations.h"

#endif

@@ -187,7 +188,7 @@ void ExtensionPopup::OnWindowActivated(aura::Window* gained_active,

if (!inspect_with_devtools_ && anchor_window == gained_active &&

host_desktop_type != chrome::HOST_DESKTOP_TYPE_ASH &&

this_window->GetRootWindow() == anchor_window->GetRootWindow() &&

- gained_active->transient_parent() != this_window)

+ views::corewm::GetTransientParent(gained_active) != this_window)

GetWidget()->Close();

}

#endif