Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1154523007: Avoid depending on Promise.prototype.toString() in layout tests (Closed)

Created:
5 years, 6 months ago by adamk
Modified:
5 years, 6 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid depending on Promise.prototype.toString() in layout tests This makes it possible to flip V8's behavior via the --harmony-tostring flag without updating Blink tests. R=arv@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M LayoutTests/fast/js/Promise-native-then.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/js/Promise-native-then-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webaudio/audiocontext-suspend-resume.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/webaudio/audiocontext-suspend-resume-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
5 years, 6 months ago (2015-06-03 20:43:36 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 6 months ago (2015-06-03 20:44:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154523007/1
5 years, 6 months ago (2015-06-03 20:45:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65120)
5 years, 6 months ago (2015-06-03 23:01:19 UTC) #7
adamk
5 years, 6 months ago (2015-06-03 23:13:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 196439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698