Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1154513002: Add ChromePublic to available browsers in telemetry. (Closed)

Created:
5 years, 7 months ago by Fabrice (no longer in Chrome)
Modified:
5 years, 7 months ago
Reviewers:
tonyg, Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ChromePublic to available browsers in telemetry. BUG=467069 Committed: https://crrev.com/43fe3d9d7e82344abf69fc72ac80248bc0f5d9ae Cr-Commit-Position: refs/heads/master@{#330986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fabrice (no longer in Chrome)
PTAL I was trying our new fancy ChromePublic and realized our telemetry tools couldn't see ...
5 years, 7 months ago (2015-05-21 16:00:34 UTC) #2
Sami
Heh, I had the same idea but you got here first :) lgtm!
5 years, 7 months ago (2015-05-21 17:16:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154513002/1
5 years, 7 months ago (2015-05-21 17:35:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 21:12:29 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 21:14:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43fe3d9d7e82344abf69fc72ac80248bc0f5d9ae
Cr-Commit-Position: refs/heads/master@{#330986}

Powered by Google App Engine
This is Rietveld 408576698