Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1154503002: cc: Make corner cases of tile priority computation more simple. (Closed)

Created:
5 years, 7 months ago by USE eero AT chromium.org
Modified:
5 years, 7 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make corner cases of tile priority computation more simple. This changes tile priority computation so that max tile priority bin has an effect only on priority bin but not on distance to visible. This affects only tiles on layers which do not have valid tile priorities. Committed: https://crrev.com/f89d183bfb64940c21e88ec802fd6c574c6a9564 Cr-Commit-Position: refs/heads/master@{#331086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M cc/tiles/picture_layer_tiling.cc View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
USE eero AT chromium.org
IMHO, as max tile priority bin does not have on effect on distance_to_visible value of ...
5 years, 7 months ago (2015-05-21 12:31:21 UTC) #2
vmpstr
Sure this makes sense. Distance to visible is only used to figure out relative ordering ...
5 years, 7 months ago (2015-05-21 17:24:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154503002/1
5 years, 7 months ago (2015-05-22 08:27:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-22 09:29:31 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 09:30:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f89d183bfb64940c21e88ec802fd6c574c6a9564
Cr-Commit-Position: refs/heads/master@{#331086}

Powered by Google App Engine
This is Rietveld 408576698