Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1154493002: Cleanup: Get rid of LayoutBlock::offsetFromLogicalTopOfFirstPage(). (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Cleanup: Get rid of LayoutBlock::offsetFromLogicalTopOfFirstPage(). Fold its contents into LayoutBox::offsetFromLogicalTopOfFirstPage() and make that one non-virtual. Some non-blocks (e.g. table rows and sections) do establish layout states, so we cannot just unconditionally jump to the containing block. Currently offsetFromLogicalTopOfFirstPage() is never called on non-blocks (in other words, the LayoutBox implementation of the method just sat there doing nothing but contribute to the binary size), which explains why we had no bugs because of this. I expect that non-blocks will call this method in the near future, though. R=jchaffraix@chromium.org,leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M Source/core/layout/LayoutBlock.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/layout/LayoutBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 7 months ago (2015-05-21 11:49:42 UTC) #1
leviw_travelin_and_unemployed
lgtm Heck yeah!
5 years, 7 months ago (2015-05-21 17:34:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154493002/1
5 years, 7 months ago (2015-05-21 17:35:14 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 17:38:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195709

Powered by Google App Engine
This is Rietveld 408576698