Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1154483002: Hook up more import/exports in natives. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Hook up more import/exports in natives. R=jkummerow@chromium.org Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 Cr-Commit-Position: refs/heads/master@{#28573} Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 Cr-Commit-Position: refs/heads/master@{#28578}

Patch Set 1 #

Total comments: 7

Patch Set 2 : addressed nits #

Patch Set 3 : do not leak utils object #

Unified diffs Side-by-side diffs Delta from patch set Stats (+705 lines, -511 lines) Patch
M src/array.js View 12 chunks +36 lines, -31 lines 0 comments Download
M src/array-iterator.js View 3 chunks +10 lines, -5 lines 0 comments Download
M src/arraybuffer.js View 2 chunks +3 lines, -4 lines 0 comments Download
M src/bootstrapper.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/collection.js View 7 chunks +17 lines, -8 lines 0 comments Download
M src/collection-iterator.js View 3 chunks +4 lines, -4 lines 0 comments Download
M src/date.js View 7 chunks +10 lines, -12 lines 0 comments Download
M src/generator.js View 3 chunks +14 lines, -5 lines 0 comments Download
M src/harmony-array.js View 1 12 chunks +23 lines, -17 lines 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-object.js View 3 chunks +13 lines, -2 lines 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 1 17 chunks +56 lines, -19 lines 0 comments Download
M src/i18n.js View 1 33 chunks +82 lines, -66 lines 0 comments Download
M src/iterator-prototype.js View 1 chunk +1 line, -1 line 0 comments Download
M src/json.js View 5 chunks +6 lines, -4 lines 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.js View 13 chunks +31 lines, -26 lines 0 comments Download
M src/object-observe.js View 7 chunks +17 lines, -9 lines 0 comments Download
M src/prologue.js View 1 2 1 chunk +180 lines, -11 lines 0 comments Download
M src/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/proxy.js View 4 chunks +21 lines, -9 lines 0 comments Download
M src/regexp.js View 16 chunks +38 lines, -35 lines 0 comments Download
M src/string.js View 13 chunks +26 lines, -20 lines 0 comments Download
M src/string-iterator.js View 5 chunks +15 lines, -6 lines 0 comments Download
M src/symbol.js View 5 chunks +14 lines, -5 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 chunk +1 line, -1 line 0 comments Download
M src/typedarray.js View 4 chunks +24 lines, -25 lines 0 comments Download
M src/uri.js View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 17 chunks +46 lines, -172 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/jsnatives.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
Yang
5 years, 7 months ago (2015-05-21 11:32:28 UTC) #1
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/1154483002/diff/1/src/harmony-array.js File src/harmony-array.js (right): https://codereview.chromium.org/1154483002/diff/1/src/harmony-array.js#newcode269 src/harmony-array.js:269: nit: surrounding code seems to be ...
5 years, 7 months ago (2015-05-21 13:45:24 UTC) #2
Erik Corry
This changes global variables into variables in functions. I know we have some optimization for ...
5 years, 7 months ago (2015-05-22 07:28:16 UTC) #4
Yang
On 2015/05/22 07:28:16, Erik Corry wrote: > This changes global variables into variables in functions. ...
5 years, 7 months ago (2015-05-22 07:55:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154483002/20001
5 years, 7 months ago (2015-05-22 08:09:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-22 08:32:59 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 Cr-Commit-Position: refs/heads/master@{#28573}
5 years, 7 months ago (2015-05-22 08:33:11 UTC) #10
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1154793003/ by machenbach@chromium.org. ...
5 years, 7 months ago (2015-05-22 08:52:52 UTC) #11
Jakob Kummerow
lgtm
5 years, 7 months ago (2015-05-22 09:32:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154483002/40001
5 years, 7 months ago (2015-05-22 10:06:19 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-22 10:32:58 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 Cr-Commit-Position: refs/heads/master@{#28578}
5 years, 7 months ago (2015-05-22 10:33:20 UTC) #16
Michael Achenbach
5 years, 7 months ago (2015-05-22 11:20:44 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1154743003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for gc stress
failures:
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-....

Powered by Google App Engine
This is Rietveld 408576698