cipd: Extract high level file system operations into the separate interface.

go/src/infra/tools/cipd/local/deployer_test.go

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package local
 
 import (
         "bytes"
         "fmt"
         "io"
@@ skipping 16 matching lines @@
                 // Wrappers that accept paths relative to tempDir.
                 touch := func(rel string) {
                         abs := filepath.Join(tempDir, filepath.FromSlash(rel))
                         err := os.MkdirAll(filepath.Dir(abs), 0777)
                         So(err, ShouldBeNil)
                         f, err := os.Create(abs)
                         So(err, ShouldBeNil)
                         f.Close()
                 }
                 ensureLink := func(symlinkRel string, target string) error {
-                        return ensureSymlink(filepath.Join(tempDir, symlinkRel), target)
+                        return os.Symlink(target, filepath.Join(tempDir, symlinkRel))
                 }
-                readLink := func(symlinkRel string) string {
-                        val, err := os.Readlink(filepath.Join(tempDir, symlinkRel))
-                        So(err, ShouldBeNil)
-                        return val
-                }
-
-                Convey("ensureSymlink creates new symlink", func() {
-                        So(ensureLink("symlink", "target"), ShouldBeNil)
-                        So(readLink("symlink"), ShouldEqual, "target")
-                })
-
-                Convey("ensureSymlink builds full path", func() {
-                        So(ensureLink(filepath.Join("a", "b", "c"), "target"), ShouldBeNil)
-                        So(readLink(filepath.Join("a", "b", "c")), ShouldEqual, "target")
-                })
-
-                Convey("ensureSymlink replaces existing one", func() {
-                        So(ensureLink("symlink", "target"), ShouldBeNil)
-                        So(ensureLink("symlink", "another"), ShouldBeNil)
-                        So(readLink("symlink"), ShouldEqual, "another")
-                })
 
                 Convey("scanPackageDir works with empty dir", func() {
                         err := os.Mkdir(filepath.Join(tempDir, "dir"), 0777)
                         So(err, ShouldBeNil)
                         files := makeStringSet()
                         err = scanPackageDir(filepath.Join(tempDir, "dir"), files)
                         So(err, ShouldBeNil)
                         So(len(files), ShouldEqual, 0)
                 })
 
@@ skipping 13 matching lines @@
                                 names = append(names, filepath.ToSlash(n))
                         }
                         names.Sort()
                         So(names, ShouldResemble, sort.StringSlice{
                                 "a/1",
                                 "a/2",
                                 "a/sym_link",
                                 "b/1",
                         })
                 })
-
-                Convey("ensureDirectoryGone works with missing dir", func() {
-                        So(ensureDirectoryGone(filepath.Join(tempDir, "missing"), nil), ShouldBeNil)
-                })
-
-                Convey("ensureDirectoryGone works", func() {
-                        touch("dir/a/1")
-                        touch("dir/a/2")
-                        touch("dir/b/1")
-                        So(ensureDirectoryGone(filepath.Join(tempDir, "dir"), nil), ShouldBeNil)
-                        _, err := os.Stat(filepath.Join(tempDir, "dir"))
-                        So(os.IsNotExist(err), ShouldBeTrue)
-                })
-
-                Convey("ensureFileGone works", func() {
-                        touch("abc")
-                        So(ensureFileGone(filepath.Join(tempDir, "abc"), nil), ShouldBeNil)
-                        _, err := os.Stat(filepath.Join(tempDir, "abc"))
-                        So(os.IsNotExist(err), ShouldBeTrue)
-                })
-
-                Convey("ensureFileGone works with missing file", func() {
-                        So(ensureFileGone(filepath.Join(tempDir, "abc"), nil), ShouldBeNil)
-                })
-
-                Convey("ensureFileGone works with symlink", func() {
-                        ensureLink("abc", "target")
-                        So(ensureFileGone(filepath.Join(tempDir, "abc"), nil), ShouldBeNil)
-                        _, err := os.Stat(filepath.Join(tempDir, "abc"))
-                        So(os.IsNotExist(err), ShouldBeTrue)
-                })
         })
 }
 
 func TestDeployInstance(t *testing.T) {
         Convey("Given a temp directory", t, func() {
                 tempDir, err := ioutil.TempDir("", "cipd_test")
                 So(err, ShouldBeNil)
                 Reset(func() { os.RemoveAll(tempDir) })
 
                 Convey("DeployInstance new empty package instance", func() {
@@ skipping 315 matching lines @@
                 }
 
                 out = append(out, item+suffix)
                 return nil
         })
         if err != nil {
                 panic("Failed to walk a directory")
         }
         return
 }