test/cctest/test-global-object.cc - Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-global-object.cc

Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-global-object.cc

diff --git a/test/cctest/test-global-object.cc b/test/cctest/test-global-object.cc

index b0ed29daf1c1947b1f37c52ae940d086ffd00885..204164ab10dea82bb9918533a6518abd14c969be 100644

--- a/test/cctest/test-global-object.cc

+++ b/test/cctest/test-global-object.cc

@@ -37,7 +37,7 @@ TEST(StrictUndeclaredGlobalVariable) {

HandleScope scope(CcTest::isolate());

v8::Local<v8::String> var_name = v8_str("x");

LocalContext context;

- v8::TryCatch try_catch;

+ v8::TryCatch try_catch(CcTest::isolate());

v8::Local<v8::Script> script = v8_compile("\"use strict\"; x = 42;");

v8::Handle<v8::Object> proto = v8::Object::New(CcTest::isolate());

v8::Handle<v8::Object> global =

« no previous file with comments | « test/cctest/test-decls.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »