src/liveedit.cc - Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/liveedit.cc

Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/liveedit.cc

diff --git a/src/liveedit.cc b/src/liveedit.cc

index 41aa83d9801ea5ec502c1c01636f09a607811a08..064a4c663b301b919969e2df67ed6097e4fd1794 100644

--- a/src/liveedit.cc

+++ b/src/liveedit.cc

@@ -844,7 +844,7 @@ MaybeHandle<JSArray> LiveEdit::GatherCompileInfo(Handle<Script> script,

{

// Creating verbose TryCatch from public API is currently the only way to

// force code save location. We do not use this the object directly.

- v8::TryCatch try_catch;

+ v8::TryCatch try_catch(reinterpret_cast<v8::Isolate*>(isolate));

try_catch.SetVerbose(true);

// A logical 'try' section.

« no previous file with comments | « src/execution.cc ('k') | src/messages.cc » ('j') | no next file with comments »