Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1154413005: Oilpan: consistently allow allocation during finalization. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: consistently allow allocation during finalization. Remove poisonHeap() assert from r196232, which insisted that the to-be-swept heap must not have had any allocations made against it. We do currently allow allocations in destructors, including for eagerly finalized objects, so the assert removal aligns with that. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/platform/heap/Heap.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 6 months ago (2015-06-02 12:21:00 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-02 13:15:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154413005/1
5 years, 6 months ago (2015-06-02 14:23:13 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 16:11:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196324

Powered by Google App Engine
This is Rietveld 408576698