chromecast/app/android/cast_crash_reporter_client_android.h - Issue 1154383006: Adding crash utilities to chromecast/crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/app/android/cast_crash_reporter_client_android.h

Issue 1154383006: Adding crash utilities to chromecast/crash. (Closed) Base URL: https://eureka-internal.googlesource.com/chromium/src@master

Patch Set: cast_shell_unittests not built for android Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/app/android/cast_crash_reporter_client_android.h

diff --git a/chromecast/crash/android/cast_crash_reporter_client_android.h b/chromecast/app/android/cast_crash_reporter_client_android.h

similarity index 78%

rename from chromecast/crash/android/cast_crash_reporter_client_android.h

rename to chromecast/app/android/cast_crash_reporter_client_android.h

index 3f296ab63bf9190902e4a15dd9e3b9653a14e7f9..9267b4c2c938e5142856d3f9cde70b8f73bf7c96 100644

--- a/chromecast/crash/android/cast_crash_reporter_client_android.h

+++ b/chromecast/app/android/cast_crash_reporter_client_android.h

@@ -2,8 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef CHROMECAST_CRASH_ANDROID_CAST_CRASH_REPORTER_CLIENT_ANDROID_H_

-#define CHROMECAST_CRASH_ANDROID_CAST_CRASH_REPORTER_CLIENT_ANDROID_H_

+#ifndef CHROMECAST_APP_ANDROID_CAST_CRASH_REPORTER_CLIENT_ANDROID_H_

+#define CHROMECAST_APP_ANDROID_CAST_CRASH_REPORTER_CLIENT_ANDROID_H_

#include "base/compiler_specific.h"

#include "components/crash/app/crash_reporter_client.h"

@@ -23,8 +23,7 @@ class CastCrashReporterClientAndroid

bool GetCrashDumpLocation(base::FilePath* crash_dir) override;

int GetAndroidMinidumpDescriptor() override;

bool GetCollectStatsConsent() override;

- bool EnableBreakpadForProcess(

- const std::string& process_type) override;

+ bool EnableBreakpadForProcess(const std::string& process_type) override;

size_t RegisterCrashKeys() override;

private:

@@ -35,4 +34,4 @@ class CastCrashReporterClientAndroid

} // namespace chromecast

-#endif // CHROMECAST_CRASH_ANDROID_CAST_CRASH_REPORTER_CLIENT_ANDROID_H_

+#endif // CHROMECAST_APP_ANDROID_CAST_CRASH_REPORTER_CLIENT_ANDROID_H_