Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chromecast/base/error_codes.h

Issue 1154383006: Adding crash utilities to chromecast/crash. (Closed) Base URL: https://eureka-internal.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/base/error_codes.h
diff --git a/chromecast/base/error_codes.h b/chromecast/base/error_codes.h
new file mode 100644
index 0000000000000000000000000000000000000000..21e51e3f362b6e982433d65e4c8389f8e99b2a46
--- /dev/null
+++ b/chromecast/base/error_codes.h
@@ -0,0 +1,46 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMECAST_BASE_ERROR_CODES_H_
+#define CHROMECAST_BASE_ERROR_CODES_H_
+
+namespace chromecast {
+
+enum ErrorCode {
alokp 2015/06/15 17:51:48 nit: I think "Code" suffix is not necessary.
gunsch 2015/06/15 18:05:59 To all of Alok's comments here: I'd actually lean
slan 2015/06/16 14:57:48 To keep this CL as clean as possible, this will be
+ NO_ERROR = 0,
alokp 2015/06/15 17:51:48 nit: ERROR_NONE
slan 2015/06/16 14:57:49 Keeping it for now.
+
+ // web_content [1, 9999]
+ ERROR_WEB_CONTENT_RENDER_VIEW_GONE = 1,
+ ERROR_WEB_CONTENT_NAME_NOT_RESOLVED,
+ ERROR_WEB_CONTENT_INTERNET_DISCONNECTED,
+
+ // reboot [10000, 19999]
+ // The following error codes do not reset the volume when the page is
+ // launched. Add codes that do not reset the volume before ERROR_REBOOT_NOW.
+ ERROR_REBOOT_NOW = 10000,
+ ERROR_REBOOT_FDR,
+ ERROR_REBOOT_OTA,
+ ERROR_REBOOT_IDLE,
+ // END_OF_REBOOT_SECTION is defined in content/shell/ui/resources/script.js
+ // So reserve 19999 here.
+ END_OF_REBOOT_SECTION = 19999,
+
+ // misc [20000, 29999]
+ ERROR_ABORTED = 20000,
+ ERROR_LOST_PEER_CONNECTION = 20001,
+
+ // The volume is reset on unknown error.
alokp 2015/06/15 17:51:48 The comment about volume is not clear to me.
slan 2015/06/16 14:57:48 I agree, this seems to be the wrong place for this
+ ERROR_UNKNOWN = 30000,
+};
+
+// Gets the error code for the first idle screen.
+ErrorCode GetInitialErrorCode();
+
+// Sets the error code for the first idle screen. Returns true if set
+// successfully.
+bool SetInitialErrorCode(ErrorCode initial_error_code);
+
+} // namespace chromecast
+
+#endif // CHROMECAST_BASE_ERROR_CODES_H_

Powered by Google App Engine
This is Rietveld 408576698