Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chromecast/chromecast.gyp

Issue 1154383006: Adding crash utilities to chromecast/crash. (Closed) Base URL: https://eureka-internal.googlesource.com/chromium/src@master
Patch Set: Linux-specific utils moved to linux/ Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/chromecast.gyp
diff --git a/chromecast/chromecast.gyp b/chromecast/chromecast.gyp
index 9519c651dd00199f7ce7d94e233879fc57ade99f..5e6fc0b63cabfb18e9997e467b31c6b7dfe2742c 100644
--- a/chromecast/chromecast.gyp
+++ b/chromecast/chromecast.gyp
@@ -62,6 +62,8 @@
'base/cast_paths.h',
'base/chromecast_switches.cc',
'base/chromecast_switches.h',
+ 'base/error_codes.cc',
+ 'base/error_codes.h',
'base/metrics/cast_histograms.h',
'base/metrics/cast_metrics_helper.cc',
'base/metrics/cast_metrics_helper.h',
@@ -76,30 +78,54 @@
],
}, # end of target 'cast_base'
{
- 'target_name': 'cast_crash_client',
+ 'target_name': 'cast_crash',
'type': '<(component)',
+ 'include_dirs': [
+ # TODO(gfhuang): we should not need to include this directly, but
+ # somehow depending on component.gyp:breakpad_component is not
+ # working as expected.
+ '../breakpad/src',
+ ],
+
'dependencies': [
+ 'cast_base',
+ 'cast_version_header',
'../breakpad/breakpad.gyp:breakpad_client',
'../components/components.gyp:crash_component',
],
+
'sources': [
+ 'crash/app_state_tracker.cc',
+ 'crash/app_state_tracker.h',
'crash/cast_crash_keys.cc',
'crash/cast_crash_keys.h',
- 'crash/cast_crash_reporter_client.cc',
- 'crash/cast_crash_reporter_client.h',
+ 'crash/cast_crashdump_uploader.cc',
+ 'crash/cast_crashdump_uploader.h',
],
+
+ #TODO(slan): This should not be necessary. Remove.
'conditions': [
- ['chromecast_branding=="Chrome"', {
- 'dependencies': [
- 'internal/chromecast_internal.gyp:crash_internal',
- ],
- }, {
+ ['OS!="android"', {
'sources': [
- 'crash/cast_crash_reporter_client_simple.cc',
+ 'crash/linux/crash_util.cc',
+ 'crash/linux/crash_util.h',
+ 'crash/linux/cast_crash_reporter_client.cc',
+ 'crash/linux/cast_crash_reporter_client.h',
+ 'crash/linux/dummy_minidump_generator.cc',
+ 'crash/linux/dummy_minidump_generator.h',
+ 'crash/linux/dump_info.cc',
+ 'crash/linux/dump_info.h',
+ 'crash/linux/minidump_generator.h',
+ 'crash/linux/minidump_manager.cc',
+ 'crash/linux/minidump_manager.h',
+ 'crash/linux/minidump_params.cc',
+ 'crash/linux/minidump_params.h',
+ 'crash/linux/minidump_writer.cc',
+ 'crash/linux/minidump_writer.h',
],
}],
- ]
- }, # end of target 'cast_crash_client'
+ ],
+ }, # end of target 'cast_crash'
{
'target_name': 'cast_net',
'type': '<(component)',
@@ -200,7 +226,7 @@
'type': '<(component)',
'dependencies': [
'cast_base',
- 'cast_crash_client',
+ 'cast_crash',
'cast_net',
'cast_shell_pak',
'cast_shell_resources',

Powered by Google App Engine
This is Rietveld 408576698