Adding crash utilities to chromecast/crash.

chromecast/chromecast.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'android_support_v13_target%':
         '../third_party/android_tools/android_tools.gyp:android_support_v13_javalib',
     'cast_build_release': 'internal/build/cast_build_release',
     'cast_is_debug_build%': 0,
@@ skipping 45 matching lines @@
       'target_name': 'cast_base',
       'type': '<(component)',
       'dependencies': [
         '../base/base.gyp:base',
       ],
       'sources': [
         'base/cast_paths.cc',
         'base/cast_paths.h',
         'base/chromecast_switches.cc',
         'base/chromecast_switches.h',
+        'base/error_codes.cc',
+        'base/error_codes.h',
         'base/metrics/cast_histograms.h',
         'base/metrics/cast_metrics_helper.cc',
         'base/metrics/cast_metrics_helper.h',
         'base/metrics/grouped_histogram.cc',
         'base/metrics/grouped_histogram.h',
         'base/path_utils.cc',
         'base/path_utils.h',
         'base/process_utils.cc',
         'base/process_utils.h',
         'base/serializers.cc',
         'base/serializers.h'
       ],
     },  # end of target 'cast_base'
     {
-      'target_name': 'cast_crash_client',
+      'target_name': 'cast_crash',
       'type': '<(component)',
+      'include_dirs': [
+        # TODO(gfhuang): we should not need to include this directly, but
+        # somehow depending on component.gyp:breakpad_component is not
+        # working as expected.
+        '../breakpad/src',
+      ],
+
       'dependencies': [
+        'cast_base',
+        'cast_version_header',
         '../breakpad/breakpad.gyp:breakpad_client',
         '../components/components.gyp:crash_component',
       ],
+
       'sources': [
+        '../content/public/common/content_switches.cc',

[gunsch, 2015/06/22 17:07:54]

whoa, when did this get added? That's definitely going to cause problems
(obviously per the build). I think I missed this during review.

+        'crash/app_state_tracker.cc',
+        'crash/app_state_tracker.h',
         'crash/cast_crash_keys.cc',
         'crash/cast_crash_keys.h',
-        'crash/cast_crash_reporter_client.cc',
-        'crash/cast_crash_reporter_client.h',
+        'crash/cast_crashdump_uploader.cc',
+        'crash/cast_crashdump_uploader.h',
+        'crash/linux/cast_crash_reporter_client.cc',
+        'crash/linux/cast_crash_reporter_client.h',
+        'crash/linux/crash_util.cc',
+        'crash/linux/crash_util.h',
+        'crash/linux/dummy_minidump_generator.cc',
+        'crash/linux/dummy_minidump_generator.h',
+        'crash/linux/dump_info.cc',
+        'crash/linux/dump_info.h',
+        'crash/linux/minidump_generator.h',
+        'crash/linux/synchronized_minidump_manager.cc',
+        'crash/linux/synchronized_minidump_manager.h',
+        'crash/linux/minidump_params.cc',
+        'crash/linux/minidump_params.h',
+        'crash/linux/minidump_writer.cc',
+        'crash/linux/minidump_writer.h',
       ],
-      'conditions': [
-        ['chromecast_branding=="Chrome"', {
-          'dependencies': [
-            'internal/chromecast_internal.gyp:crash_internal',
-          ],
-        }, {
-          'sources': [
-            'crash/cast_crash_reporter_client_simple.cc',
-          ],
-        }],
-      ]
-    },  # end of target 'cast_crash_client'
+    },  # end of target 'cast_crash'
     {
       'target_name': 'cast_net',
       'type': '<(component)',
       'sources': [
         'net/connectivity_checker.cc',
         'net/connectivity_checker.h',
         'net/connectivity_checker_impl.cc',
         'net/connectivity_checker_impl.h',
         'net/fake_connectivity_checker.cc',
         'net/fake_connectivity_checker.h',
@@ skipping 80 matching lines @@
         }],
       ],
     },  # end of target 'cast_shell_pak'
     # This target contains all content-embedder implementation that is
     # non-platform-specific.
     {
       'target_name': 'cast_shell_common',
       'type': '<(component)',
       'dependencies': [
         'cast_base',
-        'cast_crash_client',
+        'cast_crash',
         'cast_net',
         'cast_shell_pak',
         'cast_shell_resources',
         'cast_sys_info',
         'cast_version_header',
         'chromecast_locales.gyp:chromecast_locales_pak',
         'chromecast_locales.gyp:chromecast_settings',
         'media/media.gyp:media_base',
         'media/media.gyp:media_cdm',
         '../base/base.gyp:base',
@@ skipping 450 matching lines @@
           'sources': [
             'graphics/cast_egl_platform_default.cc',
             'graphics/graphics_properties_default.cc',
             'graphics/osd_plane_default.cc'
           ],
         }
       ]
     }],
   ],  # end of conditions
 }