Adding crash utilities to chromecast/crash.

chromecast/media/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//testing/test.gni")
 
 group("media") {
   deps = [
     "//chromecast/media/base",
     "//chromecast/media/cdm",
     "//chromecast/media/cma",
   ]
 }
 
-test("unittests") {
+test("cast_media_unittests") {

[alokp, 2015/06/15 17:51:49]

I would keep the target name as unittests and add an output name so that it does
not conflict with other targets in the out directory. Referencing this target
from other GN files looks prettier that way.

[gunsch, 2015/06/15 18:05:59]

Disagreed. See:
https://code.google.com/p/chromium/codesearch#search/&q=file:BUILD.gn$%20_uni...

Convention seems to be to use full test name.

[alokp, 2015/06/15 18:14:40]

You are right. Thanks for including the search results.

[slan, 2015/06/16 14:57:49]

Acknowledged.

   sources = [
     "//media/base",
     "cma/backend/audio_video_pipeline_device_unittest.cc",
     "cma/base/balanced_media_task_runner_unittest.cc",
     "cma/base/buffering_controller_unittest.cc",
     "cma/base/buffering_frame_provider_unittest.cc",
     "cma/filters/demuxer_stream_adapter_unittest.cc",
     "cma/filters/multi_demuxer_stream_adapter_unittest.cc",
     "cma/ipc/media_message_fifo_unittest.cc",
     "cma/ipc/media_message_unittest.cc",
@@ skipping 21 matching lines @@
     "//base/test:test_support",
     "//chromecast/base/metrics:test_support",
     "//media",
     "//media/base:test_support",
     "//testing/gmock",
     "//testing/gtest",
   ]
 
   configs += [ "//chromecast:config" ]
 }