Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chromecast/crash/cast_crash_reporter_client_uploader.cc

Issue 1154383006: Adding crash utilities to chromecast/crash. (Closed) Base URL: https://eureka-internal.googlesource.com/chromium/src@master
Patch Set: Corrected version hack in breakpad_util. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chromecast/crash/cast_crash_reporter_client.h"
6
7 #include "chromecast/base/error_codes.h"
8 #include "chromecast/crash/breakpad_util.h"
9
10 namespace chromecast {
11
12 bool CastCrashReporterClient::HandleCrashDump(const char* crashdump_filename) {
gunsch 2015/06/09 18:46:19 This can just get inlined into cast_crash_reporter
slan 2015/06/10 01:49:13 Done.
13 // Set the initial error code to ERROR_WEB_CONTENT_RENDER_VIEW_GONE to show
14 // an error message on next cast_shell run. Though the error code is for
15 // renderer process crash, the actual messages can be used for browser process
16 // as well.
17 if (!GetProcessType() || !strcmp(GetProcessType(), "browser"))
18 SetInitialErrorCode(ERROR_WEB_CONTENT_RENDER_VIEW_GONE);
19
20 // Upload crash dump. If user didn't opt-in crash report, minidump writer
21 // instantiated within BreakpadUtil::RequestUploadCrashDump() does nothing.
22 BreakpadUtil::RequestUploadCrashDump(
23 crashdump_filename, GetProcessType(), GetProcessStartTime());
24
25 // Always return true to indicate that this crash dump has been processed,
26 // so that it won't fallback to use chrome's default uploader.
27 return true;
28 }
29
30 } // namespace chromecast
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698