Tools/Scripts/webkitpy/layout_tests/servers/server_base.py - Issue 1154373005: Introduce WPTServe for running W3C Blink Layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

Issue 1154373005: Introduce WPTServe for running W3C Blink Layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add executable bit to pass permchecks. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py ('k') | Tools/Scripts/webkitpy/layout_tests/servers/wptserve.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py b/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

index 1d6a3e1138acf6b5700861b71c0977076879dba1..16d1dd20e0dfac11f14ef7102ec73ce7d9e67b8e 100644

--- a/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

+++ b/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py

@@ -72,6 +72,7 @@ class ServerBase(object):

# Subclasses may override these fields.

self._env = None

+ self._cwd = None

self._stdout = self._executive.PIPE

self._stderr = self._executive.PIPE

self._process = None

@@ -162,8 +163,12 @@ class ServerBase(object):

def _spawn_process(self):

_log.debug('Starting %s server, cmd="%s"' % (self._name, self._start_cmd))

- process = self._executive.popen(self._start_cmd, env=self._env, stdout=self._stdout, stderr=self._stderr)

- pid = process.pid

+ self._process = self._executive.popen(self._start_cmd,

+ env=self._env,

+ cwd=self._cwd,

+ stdout=self._stdout,

+ stderr=self._stderr)

+ pid = self._process.pid

self._filesystem.write_text_file(self._pid_file, str(pid))

return pid