Tools/Scripts/webkitpy/common/system/executive.py - Issue 1154373005: Introduce WPTServe for running W3C Blink Layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/common/system/executive.py

Issue 1154373005: Introduce WPTServe for running W3C Blink Layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix nits, refactor, license header update. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/WPT_DISABLED ('K') | « LayoutTests/WPT_DISABLED ('k') | Tools/Scripts/webkitpy/layout_tests/controllers/manager.py » ('j') | Tools/Scripts/webkitpy/layout_tests/controllers/manager.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/common/system/executive.py

diff --git a/Tools/Scripts/webkitpy/common/system/executive.py b/Tools/Scripts/webkitpy/common/system/executive.py

index 5d53ab9b57c7e849a5d100ec5cd8be2064d0061b..d76f385b7cc56ef50da277f38507743afe66b92f 100644

--- a/Tools/Scripts/webkitpy/common/system/executive.py

+++ b/Tools/Scripts/webkitpy/common/system/executive.py

@@ -86,6 +86,7 @@ class ScriptError(Exception):

class Executive(object):

PIPE = subprocess.PIPE

STDOUT = subprocess.STDOUT

+ DEVNULL = open(os.devnull, 'wb')

def _should_close_fds(self):

# We need to pass close_fds=True to work around Python bug #2320