Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/localpaths.py - Issue 1154373005: Introduce WPTServe for running W3C Blink Layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/localpaths.py

Issue 1154373005: Introduce WPTServe for running W3C Blink Layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: USE 127.0.0.1 as WPT host. Skip checking subdomains. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Tools/Scripts/webkitpy/thirdparty/wpt/README.chromium ('K') | « Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/__init__.py ('k') | Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/__init__.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 import os
	Dirk Pranke 2015/06/15 23:41:48 Can we drop this file from the import? I don't thi Can we drop this file from the import? I don't think we need it ... burnik 2015/06/16 09:24:34 This is third party code (run as part of WPT serve Show quoted text On 2015/06/15 23:41:48, Dirk Pranke wrote: > Can we drop this file from the import? I don't think we need it ... This is third party code (run as part of WPT serve). If I start here, I'll change the whole thing, which will kill the effort to use third party updates. :-) Dirk Pranke 2015/06/17 04:19:39 I don't understand; can't you just remove localpat Show quoted text On 2015/06/16 09:24:34, burnik wrote: > On 2015/06/15 23:41:48, Dirk Pranke wrote: > > Can we drop this file from the import? I don't think we need it ... > > This is third party code (run as part of WPT serve). > If I start here, I'll change the whole thing, which will kill the effort > to use third party updates. :-) I don't understand; can't you just remove localpaths.py from the list in WPTWhitelist and re-run the checkout script so that we're not adding this file? Maybe I don't understand your concern? burnik 2015/06/17 08:24:27 It's being imported in thirdparty/wpt/wpt/tools/se Show quoted text On 2015/06/16 09:24:34, burnik wrote: > On 2015/06/15 23:41:48, Dirk Pranke wrote: > > Can we drop this file from the import? I don't think we need it ... > > This is third party code (run as part of WPT serve). > If I start here, I'll change the whole thing, which will kill the effort > to use third party updates. :-) It's being imported in thirdparty/wpt/wpt/tools/serve.py from .. import localpaths So I could possibly get rid of it, however, then the changes to the third party code are no longer just pure "reduction" in terms of deleting files, it would require actual changes to the code itself (hence even more difficult to get updates). Ideally we would be using a single file for the whole WPTServe and not care about this at all. It would be nice if WPT contributors had some API release plan with at least some guarantees so we could transition to newer versions easier... I am thinking about writing some small integration tests to help this transitioning process for the future. I am sure that wptserve and wpt-tools will get a bunch of updates and some of them are bound to be a breaking change for us. We should discuss this further in the design doc.
	2 import sys

	3

	4 here = os.path.abspath(os.path.split(__file__)[0])

	5 repo_root = os.path.abspath(os.path.join(here, os.pardir))

	6

	7 sys.path.insert(0, os.path.join(repo_root, "tools"))

	8 sys.path.insert(0, os.path.join(repo_root, "tools", "six"))

	9 sys.path.insert(0, os.path.join(repo_root, "tools", "html5lib"))

	10 sys.path.insert(0, os.path.join(repo_root, "tools", "wptserve"))

	11 sys.path.insert(0, os.path.join(repo_root, "tools", "pywebsocket", "src"))

OLD	NEW