Tools/Scripts/webkitpy/layout_tests/servers/wpt_support/WPTSubmodules - Issue 1154373005: Introduce WPTServe for running W3C Blink Layout tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/servers/wpt_support/WPTSubmodules

Issue 1154373005: Introduce WPTServe for running W3C Blink Layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix nits, refactor, license header update. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py ('K') | « Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py ('k') | Tools/Scripts/webkitpy/layout_tests/servers/wpt_support/WPTWhiteList » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 ./ tools master

	2 ./tools six 3b6173c833d217ab0186c355804f5925cbcfca47

	3 ./tools pywebsocket 8c285d9015121e8c1c40be852439fc03b4a18112

	4 ./tools wptserve 9d72fe9eaef7923c4ff1ae61c05d8b6f93bbd5b6

	5 ./tools testdata a9badff0cd2fe337170769d42ca2df5e96d30f97

	6 ./tools html5lib 7cce65bbaa78411f98b8b37eeefc9db03c580097
	Dirk Pranke 2015/06/05 18:27:49 Where does this list come from? We have pywebsock Where does this list come from? We have pywebsocket already in src/third_party I don't see any reference to six or html5lib in wptserve, and I don't know what testdata is? wptserve is tiny, so I would just check include it directly in this patch under webkitpy/third_party, and I think you can skip this whole checkout step? (apart from maybe still wanting the full wpt repo, of course). burnik 2015/06/08 12:37:01 I am actually checking out web-platform-tests and Show quoted text On 2015/06/05 18:27:49, Dirk Pranke wrote: > Where does this list come from? > > We have pywebsocket already in src/third_party > > I don't see any reference to six or html5lib in wptserve, and I don't know what > testdata is? > > wptserve is tiny, so I would just check include it directly in this patch under > webkitpy/third_party, and I think you can skip this whole checkout step? > > (apart from maybe still wanting the full wpt repo, of course). I am actually checking out web-platform-tests and removing unneeded submodules and other files (tests). I do this because wptserve is very basic, however ./serve is already starting up all servers (HTTP/S + WS/S). The list is coming from my inspection of the repo HEADs which I assume to be good. My intention was to allow gradual rolling of new stuff in WPT to prevent breaking changes with this list, however this would have to be coordinated with our mirror repos as well. I'll dive in more into DEPS approach as I progress. Yes, I am aware that the pywebsocket module is redundant (as noted in the design doc). I'll have to recheck why I included testdata, I think it's not required to remain here.
OLD	NEW