Tools/Scripts/webkitpy/layout_tests/port/android.py - Issue 1154343007: Add extra content_shell per worker for virtual tests, except on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/android.py

Issue 1154343007: Add extra content_shell per worker for virtual tests, except on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: merge Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/port/android.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/android.py b/Tools/Scripts/webkitpy/layout_tests/port/android.py

index 61e3d05d53007e443a737ef54750a1f461db09a6..ada4655ebd3caed41667ff57d8c3136348a4562c 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/android.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/android.py

@@ -479,6 +479,11 @@ class AndroidPort(base.Port):

raise test_run_results.TestRunException(test_run_results.NO_DEVICES_EXIT_STATUS, "Unable to find any attached Android devices.")

return len(usable_devices)

+ def max_drivers_per_process(self):

+ # Android falls over when we try to run multiple content_shells per worker.

+ # See https://codereview.chromium.org/1158323009/

+ return 1

def check_wdiff(self, logging=True):

return self._host_port.check_wdiff(logging)