Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(136)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1154313004: Stop using deprecatedCreateWithCanvas in SP mode in PageOverlayTest. (Closed)

Created:
4 years, 11 months ago by chrishtr
Modified:
4 years, 11 months ago
Reviewers:
wkorman
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Stop using deprecatedCreateWithCanvas in SP mode in PageOverlayTest. BUG=486830 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196623

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M Source/web/PageOverlayTest.cpp View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chrishtr
4 years, 11 months ago (2015-06-06 00:33:17 UTC) #2
chrishtr
https://codereview.chromium.org/1154313004/diff/1/Source/web/PageOverlayTest.cpp File Source/web/PageOverlayTest.cpp (right): https://codereview.chromium.org/1154313004/diff/1/Source/web/PageOverlayTest.cpp#newcode206 Source/web/PageOverlayTest.cpp:206: graphicsContext.beginRecording(IntRect(rect)); These lines of code are identical to what ...
4 years, 11 months ago (2015-06-06 00:34:03 UTC) #3
wkorman
lgtm https://codereview.chromium.org/1154313004/diff/1/Source/web/PageOverlayTest.cpp File Source/web/PageOverlayTest.cpp (right): https://codereview.chromium.org/1154313004/diff/1/Source/web/PageOverlayTest.cpp#newcode204 Source/web/PageOverlayTest.cpp:204: graphicsLayer->paint(graphicsContext, WebRect(0, 0, viewportWidth, viewportHeight)); Looks like can ...
4 years, 11 months ago (2015-06-06 05:02:47 UTC) #4
chrishtr
https://codereview.chromium.org/1154313004/diff/1/Source/web/PageOverlayTest.cpp File Source/web/PageOverlayTest.cpp (right): https://codereview.chromium.org/1154313004/diff/1/Source/web/PageOverlayTest.cpp#newcode206 Source/web/PageOverlayTest.cpp:206: graphicsContext.beginRecording(IntRect(rect)); On 2015/06/06 at 00:34:02, chrishtr wrote: > These ...
4 years, 11 months ago (2015-06-06 05:13:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154313004/20001
4 years, 11 months ago (2015-06-06 05:13:19 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-06-06 06:37:08 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196623

Powered by Google App Engine
This is Rietveld 408576698