Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: base/base.gyp

Issue 1154313003: Non-SFI mode: Implement test launcher for nacl_helper_nonsfi_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base_nacl.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 76877ffefad9c81ab2e29c0c378bbdebd4038ce7..12f7c49344d6f6ccd5eb700f928f7b05695329e7 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -905,6 +905,8 @@
'test/expectations/parser.h',
'test/gtest_util.cc',
'test/gtest_util.h',
+ 'test/gtest_xml_unittest_result_printer.cc',
+ 'test/gtest_xml_unittest_result_printer.h',
'test/gtest_xml_util.cc',
'test/gtest_xml_util.h',
'test/histogram_tester.cc',
@@ -1058,6 +1060,20 @@
},
],
}],
+ ['disable_nacl==0 and disable_nacl_untrusted==0 and enable_nacl_nonsfi_test==1', {
Nico 2015/06/04 18:13:41 nit: the preferred pattern is to define the target
hidehiko 2015/06/04 19:38:09 Sure, done. Note: I kept remaining rules as is in
+ 'targets': [
+ {
+ 'target_name': 'test_launcher_nacl_nonsfi',
+ 'type': 'static_library',
+ 'sources': [
+ 'test/launcher/test_launcher_nacl_nonsfi.cc',
+ ],
+ 'dependencies': [
+ 'test_support_base',
+ ],
+ },
+ ],
+ }],
['OS!="ios"', {
'targets': [
{
« no previous file with comments | « no previous file | base/base_nacl.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698