Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1154313002: Removed unused functions in PPB_PDF (Closed)

Created:
5 years, 6 months ago by raymes
Modified:
5 years, 6 months ago
Reviewers:
Tom Sepez, Sam McNally
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unused functions in PPB_PDF There are a bunch of PPB_PDF functions that are now unused. Delete them. BUG=303491 Committed: https://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf Cr-Commit-Position: refs/heads/master@{#331899}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -507 lines) Patch
M components/pdf.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/pdf/renderer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/pdf/renderer/pdf_resource_util.h View 1 chunk +0 lines, -18 lines 0 comments Download
D components/pdf/renderer/pdf_resource_util.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M components/pdf/renderer/pepper_pdf_host.cc View 1 3 chunks +23 lines, -1 line 0 comments Download
D ppapi/api/private/finish_writing_these/ppb_pdf.idl View 1 chunk +0 lines, -165 lines 0 comments Download
M ppapi/c/private/ppb_pdf.h View 4 chunks +0 lines, -69 lines 0 comments Download
M ppapi/cpp/private/pdf.h View 3 chunks +0 lines, -10 lines 0 comments Download
M ppapi/cpp/private/pdf.cc View 3 chunks +0 lines, -52 lines 0 comments Download
M ppapi/proxy/pdf_resource.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ppapi/proxy/pdf_resource.cc View 3 chunks +0 lines, -41 lines 0 comments Download
M ppapi/proxy/pdf_resource_unittest.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 2 chunks +0 lines, -13 lines 0 comments Download
M ppapi/thunk/ppb_pdf_api.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_pdf_thunk.cc View 4 chunks +0 lines, -42 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
raymes
5 years, 6 months ago (2015-05-27 04:14:50 UTC) #2
Sam McNally
lgtm https://codereview.chromium.org/1154313002/diff/1/components/pdf/renderer/pepper_pdf_host.cc File components/pdf/renderer/pepper_pdf_host.cc (right): https://codereview.chromium.org/1154313002/diff/1/components/pdf/renderer/pepper_pdf_host.cc#newcode7 components/pdf/renderer/pepper_pdf_host.cc:7: #include "base/strings/utf_string_conversions.h" Remove. https://codereview.chromium.org/1154313002/diff/1/components/pdf/renderer/pepper_pdf_host.cc#newcode15 components/pdf/renderer/pepper_pdf_host.cc:15: #include "grit/components_scaled_resources.h" Remove.
5 years, 6 months ago (2015-05-27 05:25:16 UTC) #3
raymes
https://codereview.chromium.org/1154313002/diff/1/components/pdf/renderer/pepper_pdf_host.cc File components/pdf/renderer/pepper_pdf_host.cc (right): https://codereview.chromium.org/1154313002/diff/1/components/pdf/renderer/pepper_pdf_host.cc#newcode7 components/pdf/renderer/pepper_pdf_host.cc:7: #include "base/strings/utf_string_conversions.h" On 2015/05/27 05:25:16, Sam McNally wrote: > ...
5 years, 6 months ago (2015-05-28 03:53:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154313002/20001
5 years, 6 months ago (2015-05-28 03:54:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/66455)
5 years, 6 months ago (2015-05-28 04:03:28 UTC) #9
raymes
+tsepez for ppapi_messages.h
5 years, 6 months ago (2015-05-28 04:28:14 UTC) #11
Tom Sepez
RS LGTM on deleting code.
5 years, 6 months ago (2015-05-28 16:22:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154313002/20001
5 years, 6 months ago (2015-05-28 23:37:14 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-29 00:49:47 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 00:50:39 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf
Cr-Commit-Position: refs/heads/master@{#331899}

Powered by Google App Engine
This is Rietveld 408576698