Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Side by Side Diff: src/mips64/debug-mips64.cc

Issue 1154303008: Vector ICs: debugger should save registers for vector store ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/debug-mips.cc ('k') | src/x64/debug-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_MIPS64 9 #if V8_TARGET_ARCH_MIPS64
10 10
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 Register slot = LoadDescriptor::SlotRegister(); 159 Register slot = LoadDescriptor::SlotRegister();
160 RegList regs = receiver.bit() | name.bit() | slot.bit(); 160 RegList regs = receiver.bit() | name.bit() | slot.bit();
161 Generate_DebugBreakCallHelper(masm, regs, 0); 161 Generate_DebugBreakCallHelper(masm, regs, 0);
162 } 162 }
163 163
164 164
165 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) { 165 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
166 Register receiver = StoreDescriptor::ReceiverRegister(); 166 Register receiver = StoreDescriptor::ReceiverRegister();
167 Register name = StoreDescriptor::NameRegister(); 167 Register name = StoreDescriptor::NameRegister();
168 Register value = StoreDescriptor::ValueRegister(); 168 Register value = StoreDescriptor::ValueRegister();
169 Generate_DebugBreakCallHelper( 169 RegList regs = receiver.bit() | name.bit() | value.bit();
170 masm, receiver.bit() | name.bit() | value.bit(), 0); 170 if (FLAG_vector_stores) {
171 regs |= VectorStoreICDescriptor::SlotRegister().bit();
172 }
173 Generate_DebugBreakCallHelper(masm, regs, 0);
171 } 174 }
172 175
173 176
174 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 177 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
175 // Calling convention for keyed IC load (from ic-mips64.cc). 178 // Calling convention for keyed IC load (from ic-mips64.cc).
176 GenerateLoadICDebugBreak(masm); 179 GenerateLoadICDebugBreak(masm);
177 } 180 }
178 181
179 182
180 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 183 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
181 // Calling convention for IC keyed store call (from ic-mips64.cc). 184 // Calling convention for IC keyed store call (from ic-mips64.cc).
182 Register receiver = StoreDescriptor::ReceiverRegister(); 185 GenerateStoreICDebugBreak(masm);
183 Register name = StoreDescriptor::NameRegister();
184 Register value = StoreDescriptor::ValueRegister();
185 Generate_DebugBreakCallHelper(
186 masm, receiver.bit() | name.bit() | value.bit(), 0);
187 } 186 }
188 187
189 188
190 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) { 189 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
191 // Register state for CompareNil IC 190 // Register state for CompareNil IC
192 // ----------- S t a t e ------------- 191 // ----------- S t a t e -------------
193 // -- a0 : value 192 // -- a0 : value
194 // ----------------------------------- 193 // -----------------------------------
195 Generate_DebugBreakCallHelper(masm, a0.bit(), 0); 194 Generate_DebugBreakCallHelper(masm, a0.bit(), 0);
196 } 195 }
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 289
291 290
292 const bool LiveEdit::kFrameDropperSupported = true; 291 const bool LiveEdit::kFrameDropperSupported = true;
293 292
294 #undef __ 293 #undef __
295 294
296 } // namespace internal 295 } // namespace internal
297 } // namespace v8 296 } // namespace v8
298 297
299 #endif // V8_TARGET_ARCH_MIPS64 298 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/debug-mips.cc ('k') | src/x64/debug-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698