Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: src/mips/debug-mips.cc

Issue 1154303008: Vector ICs: debugger should save registers for vector store ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | src/mips64/debug-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_MIPS 9 #if V8_TARGET_ARCH_MIPS
10 10
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 RegList regs = receiver.bit() | name.bit() | slot.bit(); 157 RegList regs = receiver.bit() | name.bit() | slot.bit();
158 Generate_DebugBreakCallHelper(masm, regs, 0); 158 Generate_DebugBreakCallHelper(masm, regs, 0);
159 } 159 }
160 160
161 161
162 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) { 162 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
163 // Calling convention for IC store (from ic-mips.cc). 163 // Calling convention for IC store (from ic-mips.cc).
164 Register receiver = StoreDescriptor::ReceiverRegister(); 164 Register receiver = StoreDescriptor::ReceiverRegister();
165 Register name = StoreDescriptor::NameRegister(); 165 Register name = StoreDescriptor::NameRegister();
166 Register value = StoreDescriptor::ValueRegister(); 166 Register value = StoreDescriptor::ValueRegister();
167 Generate_DebugBreakCallHelper( 167 RegList regs = receiver.bit() | name.bit() | value.bit();
168 masm, receiver.bit() | name.bit() | value.bit(), 0); 168 if (FLAG_vector_stores) {
169 regs |= VectorStoreICDescriptor::SlotRegister().bit();
170 }
171 Generate_DebugBreakCallHelper(masm, regs, 0);
169 } 172 }
170 173
171 174
172 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 175 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
173 // Calling convention for keyed IC load (from ic-mips.cc). 176 // Calling convention for keyed IC load (from ic-mips.cc).
174 GenerateLoadICDebugBreak(masm); 177 GenerateLoadICDebugBreak(masm);
175 } 178 }
176 179
177 180
178 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 181 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
179 // Calling convention for IC keyed store call (from ic-mips.cc). 182 // Calling convention for IC keyed store call (from ic-mips.cc).
180 Register receiver = StoreDescriptor::ReceiverRegister(); 183 GenerateStoreICDebugBreak(masm);
181 Register name = StoreDescriptor::NameRegister();
182 Register value = StoreDescriptor::ValueRegister();
183 Generate_DebugBreakCallHelper(
184 masm, receiver.bit() | name.bit() | value.bit(), 0);
185 } 184 }
186 185
187 186
188 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) { 187 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
189 // Register state for CompareNil IC 188 // Register state for CompareNil IC
190 // ----------- S t a t e ------------- 189 // ----------- S t a t e -------------
191 // -- a0 : value 190 // -- a0 : value
192 // ----------------------------------- 191 // -----------------------------------
193 Generate_DebugBreakCallHelper(masm, a0.bit(), 0); 192 Generate_DebugBreakCallHelper(masm, a0.bit(), 0);
194 } 193 }
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 286
288 287
289 const bool LiveEdit::kFrameDropperSupported = true; 288 const bool LiveEdit::kFrameDropperSupported = true;
290 289
291 #undef __ 290 #undef __
292 291
293 } // namespace internal 292 } // namespace internal
294 } // namespace v8 293 } // namespace v8
295 294
296 #endif // V8_TARGET_ARCH_MIPS 295 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | src/mips64/debug-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698