Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 1154303008: Vector ICs: debugger should save registers for vector store ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/debug-arm64.cc ('k') | src/mips/debug-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 RegList regs = receiver.bit() | name.bit() | slot.bit(); 187 RegList regs = receiver.bit() | name.bit() | slot.bit();
188 Generate_DebugBreakCallHelper(masm, regs, 0, false); 188 Generate_DebugBreakCallHelper(masm, regs, 0, false);
189 } 189 }
190 190
191 191
192 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) { 192 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
193 // Register state for IC store call (from ic-ia32.cc). 193 // Register state for IC store call (from ic-ia32.cc).
194 Register receiver = StoreDescriptor::ReceiverRegister(); 194 Register receiver = StoreDescriptor::ReceiverRegister();
195 Register name = StoreDescriptor::NameRegister(); 195 Register name = StoreDescriptor::NameRegister();
196 Register value = StoreDescriptor::ValueRegister(); 196 Register value = StoreDescriptor::ValueRegister();
197 Generate_DebugBreakCallHelper( 197 RegList regs = receiver.bit() | name.bit() | value.bit();
198 masm, receiver.bit() | name.bit() | value.bit(), 0, false); 198 if (FLAG_vector_stores) {
199 regs |= VectorStoreICDescriptor::SlotRegister().bit();
200 }
201 Generate_DebugBreakCallHelper(masm, regs, 0, false);
199 } 202 }
200 203
201 204
202 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 205 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
203 // Register state for keyed IC load call (from ic-ia32.cc). 206 // Register state for keyed IC load call (from ic-ia32.cc).
204 GenerateLoadICDebugBreak(masm); 207 GenerateLoadICDebugBreak(masm);
205 } 208 }
206 209
207 210
208 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 211 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
209 // Register state for keyed IC store call (from ic-ia32.cc). 212 // Register state for keyed IC store call (from ic-ia32.cc).
210 Register receiver = StoreDescriptor::ReceiverRegister(); 213 GenerateStoreICDebugBreak(masm);
211 Register name = StoreDescriptor::NameRegister();
212 Register value = StoreDescriptor::ValueRegister();
213 Generate_DebugBreakCallHelper(
214 masm, receiver.bit() | name.bit() | value.bit(), 0, false);
215 } 214 }
216 215
217 216
218 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) { 217 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
219 // Register state for CompareNil IC 218 // Register state for CompareNil IC
220 // ----------- S t a t e ------------- 219 // ----------- S t a t e -------------
221 // -- eax : value 220 // -- eax : value
222 // ----------------------------------- 221 // -----------------------------------
223 Generate_DebugBreakCallHelper(masm, eax.bit(), 0, false); 222 Generate_DebugBreakCallHelper(masm, eax.bit(), 0, false);
224 } 223 }
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 320
322 321
323 const bool LiveEdit::kFrameDropperSupported = true; 322 const bool LiveEdit::kFrameDropperSupported = true;
324 323
325 #undef __ 324 #undef __
326 325
327 } // namespace internal 326 } // namespace internal
328 } // namespace v8 327 } // namespace v8
329 328
330 #endif // V8_TARGET_ARCH_IA32 329 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm64/debug-arm64.cc ('k') | src/mips/debug-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698