Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/arm64/debug-arm64.cc

Issue 1154303008: Vector ICs: debugger should save registers for vector store ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/debug-arm.cc ('k') | src/ia32/debug-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 RegList regs = receiver.Bit() | name.Bit() | slot.Bit(); 211 RegList regs = receiver.Bit() | name.Bit() | slot.Bit();
212 Generate_DebugBreakCallHelper(masm, regs, 0, x10); 212 Generate_DebugBreakCallHelper(masm, regs, 0, x10);
213 } 213 }
214 214
215 215
216 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) { 216 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
217 // Calling convention for IC store (from ic-arm64.cc). 217 // Calling convention for IC store (from ic-arm64.cc).
218 Register receiver = StoreDescriptor::ReceiverRegister(); 218 Register receiver = StoreDescriptor::ReceiverRegister();
219 Register name = StoreDescriptor::NameRegister(); 219 Register name = StoreDescriptor::NameRegister();
220 Register value = StoreDescriptor::ValueRegister(); 220 Register value = StoreDescriptor::ValueRegister();
221 Generate_DebugBreakCallHelper( 221 RegList regs = receiver.Bit() | name.Bit() | value.Bit();
222 masm, receiver.Bit() | name.Bit() | value.Bit(), 0, x10); 222 if (FLAG_vector_stores) {
223 regs |= VectorStoreICDescriptor::SlotRegister().Bit();
224 }
225 Generate_DebugBreakCallHelper(masm, regs, 0, x10);
223 } 226 }
224 227
225 228
226 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 229 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
227 // Calling convention for keyed IC load (from ic-arm.cc). 230 // Calling convention for keyed IC load (from ic-arm.cc).
228 GenerateLoadICDebugBreak(masm); 231 GenerateLoadICDebugBreak(masm);
229 } 232 }
230 233
231 234
232 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 235 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
233 // Calling convention for IC keyed store call (from ic-arm64.cc). 236 // Calling convention for IC keyed store call (from ic-arm64.cc).
234 Register receiver = StoreDescriptor::ReceiverRegister(); 237 GenerateStoreICDebugBreak(masm);
235 Register name = StoreDescriptor::NameRegister();
236 Register value = StoreDescriptor::ValueRegister();
237 Generate_DebugBreakCallHelper(
238 masm, receiver.Bit() | name.Bit() | value.Bit(), 0, x10);
239 } 238 }
240 239
241 240
242 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) { 241 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
243 // Register state for CompareNil IC 242 // Register state for CompareNil IC
244 // ----------- S t a t e ------------- 243 // ----------- S t a t e -------------
245 // -- r0 : value 244 // -- r0 : value
246 // ----------------------------------- 245 // -----------------------------------
247 Generate_DebugBreakCallHelper(masm, x0.Bit(), 0, x10); 246 Generate_DebugBreakCallHelper(masm, x0.Bit(), 0, x10);
248 } 247 }
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 __ Br(scratch); 340 __ Br(scratch);
342 } 341 }
343 342
344 343
345 const bool LiveEdit::kFrameDropperSupported = true; 344 const bool LiveEdit::kFrameDropperSupported = true;
346 345
347 } // namespace internal 346 } // namespace internal
348 } // namespace v8 347 } // namespace v8
349 348
350 #endif // V8_TARGET_ARCH_ARM64 349 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/debug-arm.cc ('k') | src/ia32/debug-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698