Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Side by Side Diff: src/arm/debug-arm.cc

Issue 1154303008: Vector ICs: debugger should save registers for vector store ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/debug-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 RegList regs = receiver.bit() | name.bit() | slot.bit(); 148 RegList regs = receiver.bit() | name.bit() | slot.bit();
149 Generate_DebugBreakCallHelper(masm, regs, 0); 149 Generate_DebugBreakCallHelper(masm, regs, 0);
150 } 150 }
151 151
152 152
153 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) { 153 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
154 // Calling convention for IC store (from ic-arm.cc). 154 // Calling convention for IC store (from ic-arm.cc).
155 Register receiver = StoreDescriptor::ReceiverRegister(); 155 Register receiver = StoreDescriptor::ReceiverRegister();
156 Register name = StoreDescriptor::NameRegister(); 156 Register name = StoreDescriptor::NameRegister();
157 Register value = StoreDescriptor::ValueRegister(); 157 Register value = StoreDescriptor::ValueRegister();
158 Generate_DebugBreakCallHelper( 158 RegList regs = receiver.bit() | name.bit() | value.bit();
159 masm, receiver.bit() | name.bit() | value.bit(), 0); 159 if (FLAG_vector_stores) {
160 regs |= VectorStoreICDescriptor::SlotRegister().bit();
161 }
162 Generate_DebugBreakCallHelper(masm, regs, 0);
160 } 163 }
161 164
162 165
163 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 166 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
164 // Calling convention for keyed IC load (from ic-arm.cc). 167 // Calling convention for keyed IC load (from ic-arm.cc).
165 GenerateLoadICDebugBreak(masm); 168 GenerateLoadICDebugBreak(masm);
166 } 169 }
167 170
168 171
169 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 172 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
170 // Calling convention for IC keyed store call (from ic-arm.cc). 173 // Calling convention for IC keyed store call (from ic-arm.cc).
171 Register receiver = StoreDescriptor::ReceiverRegister(); 174 GenerateStoreICDebugBreak(masm);
172 Register name = StoreDescriptor::NameRegister();
173 Register value = StoreDescriptor::ValueRegister();
174 Generate_DebugBreakCallHelper(
175 masm, receiver.bit() | name.bit() | value.bit(), 0);
176 } 175 }
177 176
178 177
179 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) { 178 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
180 // Register state for CompareNil IC 179 // Register state for CompareNil IC
181 // ----------- S t a t e ------------- 180 // ----------- S t a t e -------------
182 // -- r0 : value 181 // -- r0 : value
183 // ----------------------------------- 182 // -----------------------------------
184 Generate_DebugBreakCallHelper(masm, r0.bit(), 0); 183 Generate_DebugBreakCallHelper(masm, r0.bit(), 0);
185 } 184 }
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 283
285 284
286 const bool LiveEdit::kFrameDropperSupported = true; 285 const bool LiveEdit::kFrameDropperSupported = true;
287 286
288 #undef __ 287 #undef __
289 288
290 } // namespace internal 289 } // namespace internal
291 } // namespace v8 290 } // namespace v8
292 291
293 #endif // V8_TARGET_ARCH_ARM 292 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/debug-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698