Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1154303008: Vector ICs: debugger should save registers for vector store ics. (Closed)

Created:
5 years, 6 months ago by mvstanton
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Vector ICs: debugger should save registers for vector store ics. BUG= R=jkummerow@chromium.org Committed: https://crrev.com/bd32a9f711cb14c2b7c34512d43e78bd24960124 Cr-Commit-Position: refs/heads/master@{#28825}

Patch Set 1 #

Patch Set 2 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -42 lines) Patch
M src/arm/debug-arm.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/arm64/debug-arm64.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/ia32/debug-ia32.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/mips/debug-mips.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/mips64/debug-mips64.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/x64/debug-x64.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Jakob, This helps in passing debugger tests :), --Michael
5 years, 6 months ago (2015-06-05 07:12:33 UTC) #1
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-08 08:30:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154303008/20001
5 years, 6 months ago (2015-06-08 08:42:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-08 09:34:40 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 09:34:57 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd32a9f711cb14c2b7c34512d43e78bd24960124
Cr-Commit-Position: refs/heads/master@{#28825}

Powered by Google App Engine
This is Rietveld 408576698