Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1154303002: [turbofan] Optimize strict equality of unique values. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize strict equality of unique values. If both inputs to JSStrictEqual/JSStrictNotEqual are unique values (i.e. values with a canonical representation), we can lower the comparison to ReferenceEqual instead of StringEqual or CompareIC. Committed: https://crrev.com/b66226a9d93f3151773a823748c5cdb20dd8c153 Cr-Commit-Position: refs/heads/master@{#28646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +13 lines, -4 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +7 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hey Jaro, Trivial optimization for strict equal. Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-05-27 04:13:07 UTC) #2
Jarin
lgtm
5 years, 7 months ago (2015-05-27 04:21:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154303002/1
5 years, 7 months ago (2015-05-27 04:21:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 04:23:33 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 04:23:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b66226a9d93f3151773a823748c5cdb20dd8c153
Cr-Commit-Position: refs/heads/master@{#28646}

Powered by Google App Engine
This is Rietveld 408576698