Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 11543020: Removed RuntimeProfilerRateLimiter class and RuntimeProfiler::IsSomeIsolateInJS. (Closed)

Created:
8 years ago by Sven Panne
Modified:
8 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Removed RuntimeProfilerRateLimiter class and RuntimeProfiler::IsSomeIsolateInJS. Removing the former was basically a consequence of removing the latter. The net effect is, apart from less code, that the signal sender thread is much more explicit about its logic now. Committed: http://code.google.com/p/v8/source/detail?r=13212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -51 lines) Patch
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/platform-cygwin.cc View 2 chunks +1 line, -2 lines 0 comments Download
src/platform-freebsd.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/platform-linux.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/platform-macos.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/platform-openbsd.cc View 2 chunks +1 line, -2 lines 0 comments Download
src/platform-solaris.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/runtime-profiler.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/runtime-profiler.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years ago (2012-12-12 15:16:51 UTC) #1
Michael Starzinger
8 years ago (2012-12-12 15:21:29 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698