Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1154283004: Fix WorkerThreadTest.GcOccursWhileIdle. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
Sami, Justin Novosad
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix WorkerThreadTest.GcOccursWhileIdle. Fixes WorkerThreadTest.GcOccursWhileIdle after the changes in https://codereview.chromium.org/1151353003. BUG=485371 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196347

Patch Set 1 #

Patch Set 2 : AtLeast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/workers/WorkerThreadTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
rmcilroy
Junov: could you please take a look, thanks. Sami: FYI
4 years, 11 months ago (2015-06-02 19:23:06 UTC) #2
Justin Novosad
On 2015/06/02 19:23:06, rmcilroy wrote: > Junov: could you please take a look, thanks. > ...
4 years, 11 months ago (2015-06-02 19:24:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283004/1
4 years, 11 months ago (2015-06-02 19:26:07 UTC) #5
Justin Novosad
You could try .Times(AtLeast(1));
4 years, 11 months ago (2015-06-02 19:28:30 UTC) #6
rmcilroy
On 2015/06/02 19:24:18, Justin Novosad wrote: > On 2015/06/02 19:23:06, rmcilroy wrote: > > Junov: ...
4 years, 11 months ago (2015-06-02 19:29:14 UTC) #7
Justin Novosad
On 2015/06/02 19:29:14, rmcilroy wrote: > On 2015/06/02 19:24:18, Justin Novosad wrote: > > On ...
4 years, 11 months ago (2015-06-02 19:29:45 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283004/20001
4 years, 11 months ago (2015-06-02 19:29:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283004/20001
4 years, 11 months ago (2015-06-02 19:30:42 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64855)
4 years, 11 months ago (2015-06-02 21:10:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283004/20001
4 years, 11 months ago (2015-06-02 21:13:57 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 21:17:54 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196347

Powered by Google App Engine
This is Rietveld 408576698