|
|
|
Created:
4 years, 11 months ago by rmcilroy Modified:
4 years, 11 months ago CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionFix WorkerThreadTest.GcOccursWhileIdle.
Fixes WorkerThreadTest.GcOccursWhileIdle after the changes in
https://codereview.chromium.org/1151353003.
BUG=485371
NOTRY=true
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196347
Patch Set 1 #Patch Set 2 : AtLeast #Messages
Total messages: 19 (8 generated)
rmcilroy@chromium.org changed reviewers: + junov@chromium.org, skyostil@chromium.org
Junov: could you please take a look, thanks. Sami: FYI
On 2015/06/02 19:23:06, rmcilroy wrote: > Junov: could you please take a look, thanks. > > Sami: FYI But the test is flaky right now, so sometime 1 is right
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283004/1
You could try .Times(AtLeast(1));
On 2015/06/02 19:24:18, Justin Novosad wrote: > On 2015/06/02 19:23:06, rmcilroy wrote: > > Junov: could you please take a look, thanks. > > > > Sami: FYI > > But the test is flaky right now, so sometime 1 is right Didn't realize it was flaking - fixed by adding AtLeast(1) instead. PTAL.
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
On 2015/06/02 19:29:14, rmcilroy wrote: > On 2015/06/02 19:24:18, Justin Novosad wrote: > > On 2015/06/02 19:23:06, rmcilroy wrote: > > > Junov: could you please take a look, thanks. > > > > > > Sami: FYI > > > > But the test is flaky right now, so sometime 1 is right > > Didn't realize it was flaking - fixed by adding AtLeast(1) instead. PTAL. lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283004/20001
The CQ bit was unchecked by rmcilroy@chromium.org
The CQ bit was checked by rmcilroy@chromium.org
The CQ bit was checked by rmcilroy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64855)
The CQ bit was checked by junov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154283004/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196347 |
Chromium Code Reviews