src/objects.cc - Issue 1154233003: Introduce v8::Object::CreateDataProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1154233003: Introduce v8::Object::CreateDataProperty (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 4301775086c73827cc58d9dfdb86102de244baa8..2eddaeaeb57a11b9ed5966172f1ece7b4a98d73d 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -5743,6 +5743,17 @@ MaybeHandle<Object> JSObject::PreventExtensions(Handle<JSObject> object) {

}

+bool JSObject::IsExtensible() {

+ if (IsJSGlobalProxy()) {

+ PrototypeIterator iter(GetIsolate(), this);

+ if (iter.IsAtEnd()) return false;

+ DCHECK(iter.GetCurrent()->IsJSGlobalObject());

+ return JSObject::cast(iter.GetCurrent())->map()->is_extensible();

+ }

+ return map()->is_extensible();

Handle<SeededNumberDictionary> JSObject::GetNormalizedElementDictionary(

Handle<JSObject> object) {

DCHECK(!object->elements()->IsDictionary());