Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: sky/shell/ui/engine.cc

Issue 1154223003: NOT FOR COMMIT: POC of using AuthenticatingURLLoader in Sky (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: updated comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/services/platform/weburlloader_impl.cc ('k') | sky/viewer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/shell/ui/engine.cc
diff --git a/sky/shell/ui/engine.cc b/sky/shell/ui/engine.cc
index 04ab9ec6137f7c9e6457f58b0239349d4577b234..8003863b82c71f1779bbc1bb722c74843674eb75 100644
--- a/sky/shell/ui/engine.cc
+++ b/sky/shell/ui/engine.cc
@@ -59,7 +59,12 @@ void Engine::Init() {
service_provider_ = CreateServiceProvider(config_.service_provider_context);
mojo::NetworkServicePtr network_service;
mojo::ConnectToService(service_provider_.get(), &network_service);
- platform_impl_.reset(new PlatformImpl(network_service.Pass()));
+
+ // TODO(blundell): Will have to either bundle in AuthenticatingURLLoader/
+ // AuthenticationService to use them in sky shell, or fall back to using
+ // NetworkService within the sky engine if the
+ // AuthenticatingURLLoaderFactory is null.
+ platform_impl_.reset(new PlatformImpl(network_service.Pass(), nullptr));
blink::initialize(platform_impl_.get());
}
« no previous file with comments | « sky/services/platform/weburlloader_impl.cc ('k') | sky/viewer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698